Escape html from translations: XSS prevention #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

vmalyk wants to merge 1 commit into kiwicommerce:master from vmalyk:html-escaping

vmalyk commented Oct 18, 2020

Hi!

PR contains recommended changes for phtml templates by Magento guide lines:

Added escapeHtml for translation phrases - XSS prevention.
Used shortcut instead echo
Used $block instead $this
Small suggestion for version phrase - used 1 phrase instead 2 with placeholder.

Please review,


          Escape html from translations: XSS prevention

d8dd7b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet