Skip to content

Conversation

@Sental
Copy link

@Sental Sental commented Nov 14, 2019

Moving $this->state->setAreaCode(\Magento\Framework\App\Area::AREA_ADMINHTML); to the execute function to stop the console error that deals with the app state and stops magento's consumers from functioning.

Moving $this->state->setAreaCode(\Magento\Framework\App\Area::AREA_ADMINHTML); to the execute function to stop the console error that deals with the app state and stops magento's consumers from functioning.
@thampe
Copy link

thampe commented Apr 29, 2020

Hi,

is there any news on merging this pull request? This seems to be a straight forward fix.

Thanks!

@thampe
Copy link

thampe commented May 19, 2020

Hi @kiwi-commerce,

is there any news on merging this pull request?

Thanks!

@peterjaap
Copy link

@kiwi-commerce when are you planning on merging and releasing this PR?

thampe added a commit to thampe/magento2-customer-password that referenced this pull request Jun 9, 2020
@thampe
Copy link

thampe commented Jun 9, 2020

Hi,

I have created a fork with all three open prs: https://packagist.org/packages/thampe/module-customer-password

If anybody wants to install this version instead.

@micwallace
Copy link

@kiwi-commerce Please merge this request! This bug breaks core Magento functionality like the message queue.

@FredericMartinez
Copy link

And New Relic support also

PHP Fatal error:  Uncaught Error: Call to a member function getId() on null in vendor/magento/module-new-relic-reporting/Model/Observer/ReportSystemCacheFlushToNewRelic.php:58
Stack trace:
#0 vendor/magento/framework/Event/Invoker/InvokerDefault.php(88): Magento\NewRelicReporting\Model\Observer\ReportSystemCacheFlushToNewRelic->execute(Object(Magento\Framework\Event\Observer))
#1 vendor/magento/framework/Event/Invoker/InvokerDefault.php(74): Magento\Framework\Event\Invoker\InvokerDefault->_callObserverMethod(Object(Magento\NewRelicReporting\Model\Observer\ReportSystemCacheFlushToNewRelic), Object(Magento\Framework\Event\Observer))
#2 vendor/magento/framework/Event/Manager.php(66): Magento\Framework\Event\Invoker\InvokerDefault->dispatch(Array, Object(Magento\Framework\Event\Observer))
#3 generated/code/Magento/Framework/Event/Manager/Proxy. in vendor/magento/module-new-relic-reporting/Model/Observer/ReportSystemCacheFlushToNewRelic.php on line 58

@jaminion
Copy link

It looks like changes have been committed to -dev matching or very similar to outstanding PRs though they aren't referenced, see e0ad7ba.

Thank you @kiwi-commerce!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants