This repository was archived by the owner on Nov 4, 2020. It is now read-only.
Created a 2.0 for this module #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* only define array once
* if features are disabled, do not enhance data for items * use better naming for the connector options
- removed config settings in favor of ACL list in Magento + added extra acl rules for other views
+ check customer + check admin user resource + added public url resolver which can be plugable
+ open for redirect rewrites + better error handling
+ this is where git comes in
Fixed Type / Typo in constructor
Update param with capital
Update LoginAsCustomerRepository.php
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also took some other fixes from other forks...
Changelog:
+module version is 2.0.0-removed config settings from module (left version number)+added all ACL records in ACL list*took @blakesaunders security fixes+removed duplicate codes+double check the acl resourceId when trying to login-deprecated and unlinked Model\Connector in favor of ACL