Skip to content

Move storage space check after Copy/Move dialog for Move operation - #4970

Open
harshsomankar123-tech wants to merge 6 commits into
kiwix:mainfrom
harshsomankar123-tech:fix/issue-4965-move-file-space-check
Open

Move storage space check after Copy/Move dialog for Move operation#4970
harshsomankar123-tech wants to merge 6 commits into
kiwix:mainfrom
harshsomankar123-tech:fix/issue-4965-move-file-space-check

Conversation

@harshsomankar123-tech

@harshsomankar123-tech harshsomankar123-tech commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Fix: #4965

Screen.Recording.2026-07-22.at.00.17.24.mov

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.92%. Comparing base (d1d11dd) to head (2f5f6d9).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ile/nav/destination/library/CopyMoveFileHandler.kt 58.33% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4970      +/-   ##
============================================
+ Coverage     80.82%   80.92%   +0.10%     
- Complexity     2354     2357       +3     
============================================
  Files           356      356              
  Lines         17106    17114       +8     
  Branches       1916     1923       +7     
============================================
+ Hits          13826    13850      +24     
+ Misses         2426     2401      -25     
- Partials        854      863       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harshsomankar123-tech
harshsomankar123-tech force-pushed the fix/issue-4965-move-file-space-check branch 4 times, most recently from fbc4e0c to 2f5f6d9 Compare July 17, 2026 16:12
@harshsomankar123-tech
harshsomankar123-tech force-pushed the fix/issue-4965-move-file-space-check branch from 2f5f6d9 to a782205 Compare July 19, 2026 13:16
@kelson42

Copy link
Copy Markdown
Collaborator

What is the status of this PR?

@harshsomankar123-tech
harshsomankar123-tech force-pushed the fix/issue-4965-move-file-space-check branch 3 times, most recently from c74d4d8 to f9d755a Compare July 21, 2026 23:42
@harshsomankar123-tech
harshsomankar123-tech marked this pull request as ready for review July 21, 2026 23:44
@kelson42
kelson42 force-pushed the fix/issue-4965-move-file-space-check branch from f9d755a to 6a25b0b Compare July 22, 2026 08:58
@harshsomankar123-tech

Copy link
Copy Markdown
Collaborator Author

@kelson42 @MohitMaliFtechiz I've made the changes, but the CI is failing. Could you PTAL when you have a chance?
Thanks!

@kelson42

Copy link
Copy Markdown
Collaborator

Sorry, it seems I have merged main here. This is an error and this should be removed.

@MohitMaliFtechiz

Copy link
Copy Markdown
Collaborator

@harshsomankar123-tech One last thing I forgot to mention #4965 (comment). Please see this comment and implement it in LocalLibrary.

@harshsomankar123-tech
harshsomankar123-tech force-pushed the fix/issue-4965-move-file-space-check branch from 85762dd to 3c15b4a Compare July 24, 2026 18:50
@harshsomankar123-tech
harshsomankar123-tech force-pushed the fix/issue-4965-move-file-space-check branch from 3c15b4a to 0fb8b8e Compare July 24, 2026 18:56
…le observer lifecycle, observe subdirectories, use async file exist check and clean up redundant calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android16: app unable to move file to library folder from device storage

3 participants