-
-
Notifications
You must be signed in to change notification settings - Fork 521
Add duplication capability to functions and outputs #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add duplication capability to functions and outputs #1411
Conversation
I see you found my clone_model function I used to duplicate dashboards/inputs. This looks great. I'll test soon to see if I notice any issues. Thanks for the PR! |
The build test test_add_all_function_devices_logged_in_as_admin seems to be failing. =========================== short test summary info ============================ I'll investigate later |
fixed my implementation to work with the clone_model -> database interactions. also had issues installing to rpi(i had previously tested on docker only), so put in some workarounds to get it running. if its too messy, i can clean that up. |
What is the purpose of the additional commands in the update-permissions section of upgrade_commands.sh? Restarting all services when permissions are set seems out of place and is likely to negatively impact some users. |
for some reason, when running setup.sh, the web server connect test doesn't pass unless i delete the mycodoflask.sock and restart all three services. i reordered the setup.sh commands and added to the reset web server command, just to pass through install. not entirely sure why that's the case. i fixed the endpoint test to work with duplication test case, although my changes may make this test less useful. either way, the duplication function and buttons work and pytest passes! |
printf "#### Ensuring socket directory permissions\n" | ||
mkdir -p /usr/local | ||
chmod 775 /usr/local | ||
chown root:mycodo /usr/local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't be changing the group of a user's /usr/local directory
Inspired by issue #1366