Skip to content

Conversation

@kjanat
Copy link
Owner

@kjanat kjanat commented May 24, 2025

This pull request updates GitHub Actions workflows to improve maintainability and functionality. The most important changes include updating the Codecov action version, modifying triggers for workflows to use workflow_call, and dynamically setting the prerelease flag in the release workflow.

Workflow updates:

  • .github/workflows/ci.yml: Updated the Codecov action from version v4 to v5, simplified configuration by removing redundant fields, and updated the token and slug parameters.
  • .github/workflows/codeql.yml: Changed the workflow trigger from push, pull_request, and schedule to workflow_call, commenting out the previous triggers to allow the workflow to be called by other workflows.
  • .github/workflows/dependency-review.yml: Updated the trigger from pull_request to workflow_call, commenting out the original trigger to allow invocation by other workflows.
  • .github/workflows/release.yml: Made the prerelease flag dynamic, setting it to true if the tag starts with v0. using the startsWith function.

@kjanat kjanat requested a review from Copilot May 24, 2025 16:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates CI and release workflows to leverage dynamic flags, reusable configurations, and newer actions.

  • Gate prerelease drafts based on tag prefixes
  • Convert CodeQL triggers to a reusable workflow_call
  • Upgrade Codecov action to v5 and adjust its parameters

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/release.yml Dynamic prerelease based on tag prefix
.github/workflows/codeql.yml Replaced individual triggers with a workflow_call
.github/workflows/ci.yml Bumped Codecov action to v5 and updated with inputs
Comments suppressed due to low confidence (3)

.github/workflows/codeql.yml:5

  • [nitpick] Commented-out trigger blocks can clutter the workflow; consider removing or moving them to documentation if they’re no longer used.
#  push:

.github/workflows/release.yml:45

  • This condition will only mark prereleases for v0.x tags; if you intend to include v1+ versions or other semver prefixes, adjust the startsWith pattern or broaden the logic.
prerelease: ${{ startsWith(github.ref, 'refs/tags/v0.') }}

.github/workflows/ci.yml:56

  • Codecov v5 may require explicit files and flags inputs to locate coverage reports; verify defaults or add those parameters to ensure reports upload correctly.
uses: codecov/codecov-action@v5

@kjanat kjanat requested a review from Copilot May 24, 2025 16:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates several GitHub Actions workflows to adjust triggering events, update action versions, and modify release conditions. Key changes include:

  • Changing the release workflow's prerelease flag to a dynamic condition.
  • Updating the dependency review and CodeQL workflows to use workflow_call as the trigger.
  • Upgrading the Codecov action in the CI workflow to v5 with updated input parameters.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
.github/workflows/release.yml Sets prerelease dynamically based on tag naming convention.
.github/workflows/dependency-review.yml Changes the trigger from pull_request to workflow_call for manual triggering.
.github/workflows/codeql.yml Switches the workflow trigger to workflow_call, disabling automated runs.
.github/workflows/ci.yml Upgrades Codecov action to v5 and modifies input keys accordingly.
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:56

  • When upgrading to Codecov v5, confirm that the new input parameters 'token' and 'slug' align with the latest documentation and your project's needs.
uses: codecov/codecov-action@v5

@kjanat kjanat self-assigned this May 24, 2025
@kjanat kjanat added bug Something isn't working documentation Improvements or additions to documentation labels May 24, 2025
@kjanat kjanat merged commit 53403b0 into master May 24, 2025
@kjanat kjanat deleted the kjanat-patch-1 branch May 24, 2025 17:38
kjanat added a commit that referenced this pull request May 24, 2025
* Update ci.yml

* Disabled codeql.yml because of private repo status

* Update release.yml to set prerelease status if tag starts with v0

* Disable dependency-review.yml because of private repo status
kjanat added a commit that referenced this pull request May 24, 2025
* Update ci.yml

* Disable codeql.yml because of private repo status

* Update release.yml to set prerelease status if tag starts with v0

* Disable dependency-review.yml because of private repo status
kjanat added a commit that referenced this pull request May 24, 2025
* Update ci.yml

* Disable codeql.yml because of private repo status

* Update release.yml to set prerelease status if tag starts with v0

* Disable dependency-review.yml because of private repo status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants