fix: prevent duplicate workflow execution on tag push #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove tag trigger from CI workflow to prevent simultaneous execution - Add Docker build job to release workflow for proper release handling - CI now only runs on branch pushes and PRs - Release workflow handles both binary releases and Docker images for tags Fixes issue where both CI and release workflows would start when pushing vX.X.X tags
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull Request Overview
This PR prevents duplicate workflow execution on tag push by removing the tag trigger from the CI workflow and shifting the Docker build to the release workflow. Key changes include:
- Removal of the tag trigger from .github/workflows/ci.yml to avoid duplicate runs.
- Addition of a new Docker Build & Push job with enhanced permission settings in .github/workflows/release.yml.
- Adjustment of event conditions for the docker job to focus only on pushes to master, develop, and feature/docker branches.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release.yml | Added Docker build job and updated permissions/metadata |
| .github/workflows/ci.yml | Removed tag triggers & release job to avoid duplicates |
Added permission to add pull-request comments
Change how BUILD_TIME is derived Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reorganizes the CI/CD workflows by removing the release process from the
ci.ymlfile and creating a dedicatedrelease.ymlworkflow. It also introduces Docker image build and push functionality in the new release workflow. The changes streamline the CI pipeline and enhance Docker integration.Workflow Reorganization:
.github/workflows/ci.yml: Removed thereleasejob, which included tasks for running release tests, building binaries, compressing binaries, and creating GitHub releases. This job has been moved to a dedicatedrelease.ymlfile..github/workflows/ci.yml: Updated thedockerjob condition to remove checks for tags and streamline its execution logic.New Release Workflow:
.github/workflows/release.yml: Added aworkflow_calltrigger to allow other workflows to invoke the release workflow. Defined environment variables (REGISTRYandIMAGE_NAME) for Docker integration..github/workflows/release.yml: Introduced adockerjob that builds and pushes Docker images using metadata extraction, multi-platform support, and caching mechanisms. This job includes steps for logging into Docker registries, setting up QEMU and Buildx, and configuring image metadata and annotations.