authentication and activity file download fix #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added two additional GET requests as suggested in kjkjava#18 (comment) this also solves kjkjava#21
updated URLs as suggested in kjkjava#18 (comment) solves kjkjava#18 (comment)
dtrachy
approved these changes
Dec 20, 2016
pe-st
referenced
this pull request
in pe-st/garmin-connect-export
Sep 5, 2018
Do nothing in decoding_decider for empty GPX data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the issues reported in #18 (gpx and tcx download) and #21 (authentication broken). Tested with GPX, TCX and Original
I'm aware that the issues has been solved on another fork but it contains major refactoring and a pull request has not been issued. This pull request contains only minimal changes to fix the issues. Hopefully it will be accepted and merged to upstream so everyone can continue to benefit from this great tool.
Thanks @tymmej for providing the new URL for file download service. Thanks @frechina for finding the trick to pass the authentication issue.