-
Notifications
You must be signed in to change notification settings - Fork 132
Original functionality has been restored. #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
emtoonst
wants to merge
41
commits into
kjkjava:master
Choose a base branch
from
moderation:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns, formatting changes for input to Google Spreadsheets.
… authentication requirements.
Fixed keyError when parsing totalFound results
Reduce maximum to 19, as everything bigger gets a 500 status:
Making activity request ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
http://connect.garmin.com/proxy/activity-search-service-1.2/json/activities?start=0&limit=1
Finished activity request ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Garmin Connect activity: [NNNNNNNNNN] (activity name)
Tue, 6 Mar 2018 10:23, 00:57:44, 11.20 Kilometers
https://connect.garmin.com/modern/proxy/download-service/export/gpx/activity/NNNNNNNNNN?full=true
Downloading file... Done. GPX data saved.
Making activity request ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
http://connect.garmin.com/proxy/activity-search-service-1.2/json/activities?start=1&limit=20
Traceback (most recent call last):
File "./gcexport.py", line 284, in <module>
result = http_req(url_gc_search + urlencode(search_params))
File "./gcexport.py", line 82, in http_req
...
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 558, in http_error_default
raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 500: Internal Server Error
Use `limit_maximum` instead of magic number
No GPS data is indicated by HTTP status 204 (no content) (reapplying commit 404165f to current state)
Write empty GPX file when there's no GPS data
…fork and issues from https://github.com/pe-st/garmin-connect-export. Signed-off-by: Michael Payne <[email protected]>
Signed-off-by: Michael Payne <[email protected]>
Signed-off-by: Michael Payne <[email protected]>
…the cookie jar. Signed-off-by: Michael Payne <[email protected]>
…. Fix print formatting. Signed-off-by: Michael Payne <[email protected]>
Signed-off-by: Michael Payne <[email protected]>
Signed-off-by: Michael Payne <[email protected]>
…urning 400). Worked out how to download the device type and version for the ride. Signed-off-by: Michael Payne <[email protected]>
Signed-off-by: Michael Payne <[email protected]>
…al number of rides. Linting via `black`. Signed-off-by: Michael Payne <[email protected]>
Signed-off-by: Michael Payne <[email protected]>
Signed-off-by: Michael Payne <[email protected]>
has to be decoded or not. Closes #14
Decide whether decoding should happen or not
…ith-dots Adds support for display names containing dots
Signed-off-by: Michael Payne <[email protected]>
Do nothing in decoding_decider for empty GPX data
- when DEVICE_DETAIL is empty/None - when ACTIVITY_DETAIL gets HTTP error 500 - when a['activityName'] is None
…allow for passing in of application and arguments. Signed-off-by: Michael Payne <[email protected]>
Add more error handling
…SON. Signed-off-by: Michael Payne <[email protected]>
Signed-off-by: Michael Payne <[email protected]>
Signed-off-by: Michael Payne <[email protected]>
Signed-off-by: Michael Payne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.