Extensions and restructuring #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewritten gcexport.py to use the GarminHandler No support yet for downloading tcx/gpx/original files.
… two post authorization requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've written a few new functions based on your code and, in the process, restructured the code to make it easier to reuse.
You can now reverse the retrieval order, from oldest to newest activity, and get the csv laps file of an acitivity. which allows retrieval of new runs up to a certain given activity. In addition, I have added a function that allows retrieval of new activities up to a certain activity.
I hope you like the restructuring. All the Garmin handling is now in the GarminHandler.py. This is used by gcexport.py, which has the same functionality as before (plus the mentioned extras), but is a lot lighter. The separate handler also allows for reusing the code in different Garmin-related projects where activities need to be retrieved.
Please let me know if you have questions or comments, both on functionality and code-style.