Fix BigInteger.modInverse DoS in shipped bundles#653
Open
Kr0emer wants to merge 1 commit intokjur:masterfrom
Open
Fix BigInteger.modInverse DoS in shipped bundles#653Kr0emer wants to merge 1 commit intokjur:masterfrom
Kr0emer wants to merge 1 commit intokjur:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a denial-of-service issue in the shipped jsrsasign bundles where
BigInteger.modInverse(0, odd_modulus)could enter an infinite loop.What changed
bnModInverseimplementations with the normalized safe logic already present in sourcemodInverse(0, 9)through the npm entrypointValidation
npm/lib/jsrsasign.jswith a timeout-based PoC before the fix0instead of hanging