Fix AWS upload deprecation#464
Conversation
|
Thanks @barnaclebarnes - would be great to see this merged. |
|
@aaronstillwell disclaimer - it was vibe coded. Hopefully works OK for everyone. 🙏 |
|
I was just checking this as I saw it failing, thanks @barnaclebarnes for the fix. |
|
Are we waiting on the 2 failing tests to pass before this can be looked at being merged? |
|
It would be great to see these tests fixed and to see this merged. |
yes |
|
Let me try and fix those in the next few days. |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
I realised I had fixed things but hadn't replied. we should be good to go? |
| /config/* | ||
| !/config/.keep | ||
|
|
||
| .claude |
There was a problem hiding this comment.
Shouldn't this be in devs' global git configuration? As a user-specific tool unrelated to the gem, it should be in their ~/.config/git/ignore file. (Users who use claude would want that path ignored in all repos, not needing to ignore it explicitly each repo they work in. That's the whole point of global gitignore.)
Per https://git-scm.com/docs/gitignore
Patterns which a user wants Git to ignore in all situations (e.g., backup or temporary files generated by the user’s editor of choice) generally go into a file specified by core.excludesFile
* upstream/master: Enhance Rails railtie to respect existing rails configuration (kjvarga#478) Improve Sitemap method-missing implementation (kjvarga#473) Fix broken specs (kjvarga#476) Simplify rake task hierarchy (kjvarga#477) Fix AWS upload deprecation (kjvarga#464)
6 participants
Fixes #459