Skip to content

Conversation

@maximeguillaud
Copy link

Add support for Baofeng UV-21 Pro V2

@maximeguillaud
Copy link
Author

Not sure if this fixes https://chirpmyradio.com/issues/10581 as I only have access to the v2 hardware.

@directory.register
class UV21ProV2(UV17Pro):
VENDOR = "Baofeng"
MODEL = "UV-21Pro-v2"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just say UV-21Pro here. Since the bug you reference doesn't mention V2 but says that the existing UV-17Pro driver works, I think your concern over V1/V2 probably means that your driver will work for both. So yes, please also add the Fixes: tag to link/close that bug.

Also, I haven't eye-diffed this, but is this actually different from any of the above models? If so, then this looks okay, but if not, I think I'd prefer to just add an entry to the model_alias_map. There are so many total clones of the UV-17 that this file is starting to get littered with them :)

Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard for me to say if this differs from other models as I don't have access to all of them to test. In https://chirpmyradio.com/issues/10581 it is suggested to use the Baofeng UV-17Pro profile with the UV-21, however the UV-17Pro profile doesn't seem to support airband.
An alternative path to fix this would be to add airband to the UV-17Pro profile (which seems to support airband according to the specs I found online) and see whether it works with both UV-17Pro and UV-21; however in that case I would not be able to test with the UV-17Pro.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay so this looks identical to the above 5RH model with the exception of the power levels. Does the UV21 really only have hi/lo?

At the very least, please subclass that and just override the POWER_LEVELS bit so it's clear that it's otherwise identical.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks maybe identical to the 17RPlus?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the UV-17R-Plus profile seems to do the trick.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should we replace this with just an update to chirp/share/model_alias_map.yaml ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants