Skip to content

Conversation

@Tommy83033
Copy link
Contributor

CHIRP PR Guidelines

The following must be true before PRs can be merged:

  1. All tests must be passing. The "PR Checks" job is speculative and failure doesn't always indicate a critial problem, but generally it needs to pass as well.
  2. Commits should be rebased (or simply rebase-able in the web UI) on current master. Do not put merge commits in a PR.
  3. Commits in a single PR should be related. Squash intermediate commits into logical units (i.e. "fix tests" commits need not survive on their own). Keep cleanup commits separate from functional changes.
  4. Major new features or bug fixes should reference a CHIRP issue in the commit message. Do this with the pattern Fixes #1234 or Related to #1234 so that the ticket system links the commit to the issue.
  5. Please write a reasonable commit message, especially if making some change that isn't totally obvious (such as adding a new model, adding a feature, etc). The first line of every commit is emailed to the users' list after each build. It should be short, but meaningful for regular users (examples: "thd74: Fixed tone decoding" or "uv5r: Added settings support").
  6. New drivers should be accompanied by a test image in tests/images (except for thin aliases where the driver is sufficiently tested already). All new drivers must use MemoryMapBytes.
  7. All files must be GPLv3 licensed or contain no license verbiage. No additional restrictions can be placed on the usage (i.e. such as noncommercial).
  8. Do not add new py2-compatibility code (No new uses of six, future, etc).

Copy link
Owner

@kk7ds kk7ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for working on this. I have only skimmed briefly, as it looks like there is a lot of work left to be done, but left a few comments for you to address as you do. The data types need to be fixed for sure. Also, the code style is very internally inconsistent and inconsistent with the rest of CHIRP. Please clean all of that up to be as close to the other code as possible (please use lowercase/underscore for function/method/variable names and CamelCase for classes).

Thanks!

@kk7ds
Copy link
Owner

kk7ds commented Aug 22, 2025

You still need to rebase and squash your intermediate commits in order to pass the PR checks. However, you can ignore that for now until after the code has been reviewed.

Copy link
Owner

@kk7ds kk7ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, but I'm afraid it still needs a lot of work. It would probably be a good idea to do some more reading of other drivers in CHIRP to get a better idea of what the conventions are.

@kk7ds kk7ds mentioned this pull request Aug 22, 2025
@Tommy83033 Tommy83033 force-pushed the master branch 4 times, most recently from af23cb5 to fae9aa4 Compare August 29, 2025 03:08
@Tommy83033 Tommy83033 requested a review from kk7ds August 30, 2025 01:32
@Tommy83033 Tommy83033 force-pushed the master branch 3 times, most recently from 6b43ff0 to 898ae3b Compare September 5, 2025 05:30
@Tommy83033 Tommy83033 force-pushed the master branch 2 times, most recently from 67bce39 to b64a723 Compare September 18, 2025 07:12
Copy link
Owner

@kk7ds kk7ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tommy, thank you for the edits so far. More comments are made here.

Please remember that someone other than you will likely need to maintain this code in the future. All of the obscure magic numbers and complex logic that have no names and comments will make it impossible for someone else to know what is going on here. Please help make the code understandable for others.

@Tommy83033 Tommy83033 requested a review from kk7ds September 25, 2025 00:39
@Tommy83033 Tommy83033 force-pushed the master branch 2 times, most recently from 16169d7 to 7001b57 Compare September 28, 2025 05:58
@Tommy83033 Tommy83033 force-pushed the master branch 5 times, most recently from e4be5cc to 2353f9d Compare October 11, 2025 01:54
Copy link
Owner

@kk7ds kk7ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tommy, please please try to go through this with a fine-toothed comb and fix typos, inconsistencies, etc. I shouldn't have to make so many comments about small items like this after so much review, but there is still a lot here to clean up.

@Tommy83033 Tommy83033 force-pushed the master branch 3 times, most recently from 3e0aeca to 4d89e4e Compare October 17, 2025 07:37
@Tommy83033 Tommy83033 requested a review from kk7ds October 17, 2025 07:38
1. Channel Module
2. Basic Settings
3. DTMF Settings
4. Scan List Settings
5. VFO Scan Settings
6. Alarm List Settings

Added Retevis HA1G.img and Retevis HA1UV.img in tests/images
@kk7ds kk7ds merged commit bf1f976 into kk7ds:master Oct 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants