Skip to content

Conversation

@BlagodarovVA
Copy link

string 1300, add fingerprint for rt-470 old pcb fw 1.27A

CHIRP PR Guidelines

The following must be true before PRs can be merged:

  1. All tests must be passing. The "PR Checks" job is speculative and failure doesn't always indicate a critial problem, but generally it needs to pass as well.
  2. Commits should be rebased (or simply rebase-able in the web UI) on current master. Do not put merge commits in a PR.
  3. Commits in a single PR should be related. Squash intermediate commits into logical units (i.e. "fix tests" commits need not survive on their own). Keep cleanup commits separate from functional changes.
  4. Major new features or bug fixes should reference a CHIRP issue in the commit message. Do this with the pattern Fixes #1234 or Related to #1234 so that the ticket system links the commit to the issue.
  5. Please write a reasonable commit message, especially if making some change that isn't totally obvious (such as adding a new model, adding a feature, etc). The first line of every commit is emailed to the users' list after each build. It should be short, but meaningful for regular users (examples: "thd74: Fixed tone decoding" or "uv5r: Added settings support"). There should be a blank line after the first, followed by additional text so that it gets formatted properly for the mailing list.
  6. New drivers should be accompanied by a test image in tests/images (except for thin aliases where the driver is sufficiently tested already). All new drivers must use MemoryMapBytes.
  7. All files must be GPLv3 licensed or contain no license verbiage. No additional restrictions can be placed on the usage (i.e. such as noncommercial).
  8. Do not add new py2-compatibility code (No new uses of six, future, etc).

string 1300, add fingerprint for rt-470 old pcb fw 1.27A
@BlagodarovVA
Copy link
Author

RT-470 added fingerprint for firmware 1.27a

Radtel RT-470 added fingerprint for firmware 1.27a

Copy link
Owner

@kk7ds kk7ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to rebase (not merge) this in order to pass the check. Also, please read the PR guidelines and fix the commit message for this in a suitable way.

Thanks!

b"\x00\x00\x00\x3A\x00\x20\xE8\x04", # fw 1.25A
b"\x00\x00\x00\x42\x00\x20\xec\x04", # fw 1.27A

b"\x00\x00\x00\x42\x00\x20\xEC\x04", # fw 1.27A
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a conflict with master since this change is already present

# BT version
_fingerprint_bt = [b"\x01\x36\x01\x80\x04\x00\x05\x20" # fw v0.15
_fingerprint_bt = [b"\x01\x36\x01\x80\x04\x00\x05\x20", # fw v0.15
b"\x01\x30\x01\x80\x04\x00\x05\x20", # there is such a print
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you're trying to add another BT fingerprint, but "there is such a print" does not make sense. Can you please replace this comment with the firmware version that matches the one you're trying to add?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants