Skip to content

Conversation

@mrtjr1
Copy link
Contributor

@mrtjr1 mrtjr1 commented Oct 10, 2025

Add 9PX Plus and 9DX to show to use 9PX driver
Add 9GX Plus to use 9GX driver

CHIRP PR Guidelines

The following must be true before PRs can be merged:

  1. All tests must be passing. The "PR Checks" job is speculative and failure doesn't always indicate a critial problem, but generally it needs to pass as well.
  2. Commits should be rebased (or simply rebase-able in the web UI) on current master. Do not put merge commits in a PR.
  3. Commits in a single PR should be related. Squash intermediate commits into logical units (i.e. "fix tests" commits need not survive on their own). Keep cleanup commits separate from functional changes.
  4. Major new features or bug fixes should reference a CHIRP issue in the commit message. Do this with the pattern Fixes #1234 or Related to #1234 so that the ticket system links the commit to the issue.
  5. Please write a reasonable commit message, especially if making some change that isn't totally obvious (such as adding a new model, adding a feature, etc). The first line of every commit is emailed to the users' list after each build. It should be short, but meaningful for regular users (examples: "thd74: Fixed tone decoding" or "uv5r: Added settings support"). There should be a blank line after the first, followed by additional text so that it gets formatted properly for the mailing list.
  6. New drivers should be accompanied by a test image in tests/images (except for thin aliases where the driver is sufficiently tested already). All new drivers must use MemoryMapBytes.
  7. All files must be GPLv3 licensed or contain no license verbiage. No additional restrictions can be placed on the usage (i.e. such as noncommercial).
  8. Do not add new py2-compatibility code (No new uses of six, future, etc).

@mrtjr1
Copy link
Contributor Author

mrtjr1 commented Oct 11, 2025

I cherry picked this commit. Not sure why it is failing. The errors are on stuff that I didn't touch. Let me know if I messed something up.

Add 9PX Plus and 9DX to show to use 9PX driver
Add 9GX Plus to use 9GX driver
@kk7ds
Copy link
Owner

kk7ds commented Oct 14, 2025

Since you weren't rebased on top of my master, the PR check was seeing a lot more change from this commit to the head of master and thus "charging you for those crimes".

@kk7ds kk7ds merged commit 1e7dd4b into kk7ds:master Oct 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants