ha1g: Remove non-reentrant alarm/dtmf list code #1416
Merged
+0
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mutates global state and thus is not reentrant and not valid behavior for a CHIRP driver. This was found while investigating the referenced bug. Since it's invalid *and* apparently broken, this patch removes the offending code until it can be made reentrant and fixed. Related to #12248
|
cc: @Tommy83033 Please take note that I'm removing this non-reentrant code. If I had realized this during review I would have had you fix this. However, note in bug 12248 that this code was failing for the reporter anyway, so I'm removing it until it can be fixed and made reentrant. Also please note that the poster is still having problems with uploads. If you could, please engage with him on the bug there and hopefully you can resolve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mutates global state and thus is not reentrant and not valid
behavior for a CHIRP driver.
This was found while investigating the referenced bug. Since it's
invalid and apparently broken, this patch removes the offending
code until it can be made reentrant and fixed.
Fixes #12248