run tests on all platforms #4
Conversation
| pep8 \ | ||
| pyserial \ | ||
| tox | ||
| - run: rm chirp/drivers/generic_xml.py |
There was a problem hiding this comment.
I would rather just remove it from the tree than have the test stuff silently behave differently here versus locally. I have a commit on the py3 branch to do it, I'll pull it over.
|
Running the tests on the master branch on windows requires using the old test runner because the setup.py is specific for py2exe. Never tried to run them on macos, but the same problem may exist with the legacy py2app stuff. Windows tests on the py3 branch should work the same as linux because that's all modernized. |
How do you do that? Use |
Yup, or run_tests.bat in windows. In either case, you have to have all the deps installed manually of course. Personally, I'm not sure it's worth running the tests on the other platforms in master, as I'm not sure it's ever caught anything platform-specific (and we don't have good enough coverage anyway). Running them on py3 should be easy though, and if we're going to catch up that branch and keep it close, then we'd get some tangential coverage that way. |
|
Actually, I've got most of the build stuff pulled out at this point anyway, so give me some time this week and I'll see if I can extricate the rest and make setup.py more normal in the tree. That'll make it possible for people to use tox on windows anyway. |
2 participants
No description provided.