samples: matter: Optimized application main loop wake up interval #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Damian-Nordic
left a comment
Damian-Nordic
left a comment
There was a problem hiding this comment.
Have some code-style comments, but looking good.
kkasperczyk-no
force-pushed
the
main_loop_optimization
branch
from
48e7ee3 to
f51d5a5
Compare
LuDuda
approved these changes
Oct 13, 2021
Currently in all Matter samples and applications main loop was refreshed every 10 ms to update LEDs state and thus resulted in frequent MCU wake ups. Introduced several changes in order to wake up MCU only on events or when LED needs a state change: * Moved updating BLE connection and Thread state from main loop to Matter event handler * Moved updating LED state from main loop to event handler * Refactored LEDWidget module to use timer and change LEDs state on timer expiration. * Modified Matter weather station events handling to be consistent with other Matter samples Signed-off-by: Kamil Kasperczyk <[email protected]>
kkasperczyk-no
force-pushed
the
main_loop_optimization
branch
from
f51d5a5 to
ef2a9ab
Compare
kkasperczyk-no
pushed a commit
that referenced
this pull request
May 13, 2024
-This manifest update and relevant commits in sdk-nrf is made to add support for nRF54H20 devices without a local build of the core -This includes taking in sdk-mbedtls pull request #15 for better client support in PK and MD wrapper APIs -This includes taking in sdk-oberon-psa-crypto pull request #10 for better client support as well as fixups for psa_util used for TLS/DTLS and X.509 testing Ref: NCSDK-15632 Signed-off-by: Frank Audun Kvamtrø <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in all Matter samples and applications main loop was
refreshed every 10 ms to update LEDs state and thus resulted
in frequent MCU wake ups. Introduced several changes in order
to wake up MCU only on events or when LED needs a state change:
to Matter event handler
on timer expiration.
with other Matter samples
Signed-off-by: Kamil Kasperczyk [email protected]