Skip to content

fix: deactivate the active server when it's modified#128

Merged
kkebo merged 1 commit into
mainfrom
127-deactivate-on-editing
Sep 3, 2025
Merged

fix: deactivate the active server when it's modified#128
kkebo merged 1 commit into
mainfrom
127-deactivate-on-editing

Conversation

@kkebo
Copy link
Copy Markdown
Owner

@kkebo kkebo commented Sep 2, 2025

fixes #127

@kkebo kkebo added this to the 1.6.0 milestone Sep 2, 2025
@kkebo kkebo self-assigned this Sep 2, 2025
@kkebo kkebo added the bug Something isn't working label Sep 2, 2025
@kkebo kkebo force-pushed the 127-deactivate-on-editing branch from 2ecda9f to 344977d Compare September 3, 2025 11:00
@kkebo kkebo enabled auto-merge September 3, 2025 11:00
@kkebo kkebo disabled auto-merge September 3, 2025 11:36
@kkebo kkebo force-pushed the 127-deactivate-on-editing branch from 344977d to fcec5ef Compare September 3, 2025 11:39
@kkebo kkebo enabled auto-merge September 3, 2025 11:40
@kkebo kkebo merged commit 17ce2d5 into main Sep 3, 2025
4 of 5 checks passed
@kkebo kkebo deleted the 127-deactivate-on-editing branch September 3, 2025 11:42
@kkebo
Copy link
Copy Markdown
Owner Author

kkebo commented Sep 4, 2025

On platforms that have a sidebar (e.g., macOS, iPadOS), if I tap on another server listed in that sidebar, this onChange event will be triggered. However, this is not what I intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editing active server's on-demand rules doesn't affect until reactivating it

1 participant