Skip to content

[INTERNAL PR] Dotnet Counters Unification#212

Open
kkeirstead wants to merge 66 commits intomainfrom
kkeirstead/unifyCounters5_MAIN
Open

[INTERNAL PR] Dotnet Counters Unification#212
kkeirstead wants to merge 66 commits intomainfrom
kkeirstead/unifyCounters5_MAIN

Conversation

@kkeirstead
Copy link
Copy Markdown
Owner

@kkeirstead kkeirstead commented Sep 8, 2023

Internal PR to solidify things before bringing this code to the main dotnet-monitor repo. Note that I expect some things still need to be tweaked, but I wanted to put this up instead of just continuing to polish it. I also plan to do another round of manual testing on this when it's in a "done" state - I did manual testing to find some minor differences prior to the shared session logic, so just to be safe I'll likely do another sanity check. There's also an accompanying PR for diagnostics here.

wiktork and others added 30 commits February 1, 2023 11:21
@wiktork
Merge pull request dotnet#3533 from dotnet/main
52d967b 
Merge main to release/8.x
@github-actions
update release information (dotnet#3534)
1e82861 
Co-authored-by: github-actions <github-actions@github.com>
@dotnet-maestro
Update dependencies from https://github.com/dotnet/diagnostics build …
538b4d5 
…20230201.1 (dotnet#3539)

Microsoft.Diagnostics.Monitoring , Microsoft.Diagnostics.Monitoring.EventPipe
 From Version 6.0.0-preview.23080.1 -> To Version 7.0.410101

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@wiktork
Use shipped version of dotnet-diagnostics (dotnet#3538)
8ced6f4
@github-actions @kkeirstead
[SDM] Reverted duration seconds from 2 to 10 seconds (dotnet#3543) (d…
1c94c83 
…otnet#3545)

Co-authored-by: kkeirstead <85592574+kkeirstead@users.noreply.github.com>
@github-actions @wiktork
Fix quantile issue for summaries (dotnet#3546) (dotnet#3551)
25ab523 
* Fix quantile issue for summaries

* Fix unit test

* Fixup labels

Co-authored-by: Wiktor Kopec <wiktork@microsoft.com>
@jander-msft
Update dependencies and SDK to 8.0 Preview 1 (dotnet#3548)
906da1b
@dependabot
Bump Microsoft.OpenApi.Readers from 1.5.0 to 1.6.0 in /eng/dependabot (…
2fdbd89 
…dotnet#3532)

Bumps [Microsoft.OpenApi.Readers](https://github.com/Microsoft/OpenAPI.NET) from 1.5.0 to 1.6.0.
- [Release notes](https://github.com/Microsoft/OpenAPI.NET/releases)
- [Commits](microsoft/OpenAPI.NET@1.5.0...1.6.0)

---
updated-dependencies:
- dependency-name: Microsoft.OpenApi.Readers
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
b1302e7 
…230203.1 (dotnet#3560)

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23102.6 -> To Version 8.0.100-preview.1.23103.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
16066cd 
…230205.2

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23103.1 -> To Version 8.0.100-preview.1.23105.2

Dependency coherency updates

Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.8.0
 From Version 8.0.0-preview.1.23081.6 -> To Version 8.0.0-preview.1.23104.3 (parent: Microsoft.Dotnet.Sdk.Internal
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
60efd0e 
…230205.3

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23103.1 -> To Version 8.0.100-preview.1.23105.3

Dependency coherency updates

Microsoft.AspNetCore.App.Runtime.win-x64,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0
 From Version 8.0.0-preview.1.23080.16 -> To Version 8.0.0-preview.1.23105.1 (parent: Microsoft.Dotnet.Sdk.Internal
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
28c2a63 
…230206.1

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23103.1 -> To Version 8.0.100-preview.1.23106.1

Dependency coherency updates

Microsoft.AspNetCore.App.Runtime.win-x64,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0
 From Version 8.0.0-preview.1.23080.16 -> To Version 8.0.0-preview.1.23105.1 (parent: Microsoft.Dotnet.Sdk.Internal
@wiktork
Merge pull request dotnet#3574 from dotnet/darc-release/8.x-0882d883-…
51b6aad 
…9876-4dcb-896d-c6a1a1672858

[release/8.x] Update dependencies from dotnet/installer
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
ab286ca 
…230207.4

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23106.1 -> To Version 8.0.100-preview.1.23107.4
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
ba2fbd6 
…230207.12

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23106.1 -> To Version 8.0.100-preview.1.23107.12

Dependency coherency updates

Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.8.0
 From Version 8.0.0-preview.1.23104.3 -> To Version 8.0.0-preview.1.23106.5 (parent: Microsoft.Dotnet.Sdk.Internal
@wiktork
Merge pull request dotnet#3582 from dotnet/darc-release/8.x-104c0b11-…
077e7f2 
…dbf5-4bcb-a72a-4275bdc3cf95

[release/8.x] Update dependencies from dotnet/installer
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
53185f3 
…230207.22

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23107.12 -> To Version 8.0.100-preview.1.23107.22
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
474f875 
…230207.34

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23107.12 -> To Version 8.0.100-preview.1.23107.34

Dependency coherency updates

Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0
 From Version 8.0.0-preview.1.23105.1 -> To Version 8.0.0-preview.1.23107.3 (parent: Microsoft.Dotnet.Sdk.Internal
@wiktork
Merge pull request dotnet#3597 from dotnet/darc-release/8.x-7f401f0c-…
c9fc6a9 
…46e3-48db-9203-0e137708d8bd

[release/8.x] Update dependencies from dotnet/installer
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
0ee6be4 
…230207.49

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23107.34 -> To Version 8.0.100-preview.1.23107.49
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
2794138 
…230208.5

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23107.34 -> To Version 8.0.100-preview.1.23108.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
4cd71eb 
…230208.8

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23107.34 -> To Version 8.0.100-preview.1.23108.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
2b851df 
…230208.10

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23107.34 -> To Version 8.0.100-preview.1.23108.10
@wiktork
Merge pull request dotnet#3599 from dotnet/darc-release/8.x-763bfe86-…
961e8e6 
…4e8b-49ea-a042-499c4a83c463

[release/8.x] Update dependencies from dotnet/installer
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
1ef11ac 
…230208.16

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23108.10 -> To Version 8.0.100-preview.1.23108.16
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
4db6ced 
…230209.3

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23108.10 -> To Version 8.0.100-preview.1.23109.3
@wiktork
Merge pull request dotnet#3609 from dotnet/darc-release/8.x-475fd4b2-…
a63c68c 
…6759-4fae-9d8b-18f9d32221fc

[release/8.x] Update dependencies from dotnet/installer
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
3839d2c 
…230209.5

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23109.3 -> To Version 8.0.100-preview.1.23109.5
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
21ee346 
…230209.8

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23109.3 -> To Version 8.0.100-preview.1.23109.8
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
3ab34c9 
…230209.10

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.1.23109.3 -> To Version 8.0.100-preview.1.23109.10
wiktork and others added 29 commits March 3, 2023 16:44
@wiktork
Merge remote-tracking branch 'upstream/main' into dev/wiktork/mergeMa…
a4839ff 
…inTo8x
@wiktork
Update Version.Details.xml
26c8a13
@jander-msft
Merge main to release/8.x (dotnet#3845)
3afcf62
@github-actions @wiktork
Fixup merge issue with schema splitting (dotnet#3848) (dotnet#3849)
fe7de57 
Co-authored-by: Wiktor Kopec <wiktork@microsoft.com>
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
8763c49 
…230303.6 (dotnet#3854)

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.2.23151.10 -> To Version 8.0.100-preview.2.23153.6

Dependency coherency updates

Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0
 From Version 8.0.0-preview.2.23128.10 -> To Version 8.0.0-preview.2.23153.2 (parent: Microsoft.Dotnet.Sdk.Internal

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@github-actions
Change call to UseApiKey to match pattern used elsewhere in Tests code (
5763ba1 
dotnet#3865)
@github-actions
Publish guardian directory after validation (dotnet#3863)
d5e05a8
@schmittjoseph
Merge remote-tracking branch 'upstream/main' into merge-main-into-rel…
7e207fc 
…ease/8.x
@schmittjoseph
Merge pull request dotnet#4102 from schmittjoseph/merge-main-into-rel…
8fd1295 
…ease/8.x

Merge `main` into `release/8.x`
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
133957c 
…230328.7 (dotnet#4108)

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.4.23176.5 -> To Version 8.0.100-preview.3.23178.7

Dependency coherency updates

Microsoft.AspNetCore.App.Runtime.win-x64,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0
 From Version 8.0.0-preview.4.23174.2 -> To Version 8.0.0-preview.3.23177.8 (parent: Microsoft.Dotnet.Sdk.Internal

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@github-actions @schmittjoseph
Use zip for version (dotnet#4149) (dotnet#4160)
5160055 
Co-authored-by: Joe Schmitt <1146681+schmittjoseph@users.noreply.github.com>
@kkeirstead
Updated versions
06162e6
@kkeirstead
Merge pull request dotnet#4341 from kkeirstead/kkeirstead/MergeMainIn…
ef65d00 
…toRelease8xP4

Merge `main` into `release/8.x`
@github-actions @wiktork
Enable workflow identity (dotnet#4313) (dotnet#4348)
921c4f9 
* Enable workflow identity

* PR Feedback and fix typos

Co-authored-by: Wiktor Kopec <wiktork@microsoft.com>
@github-actions @wiktork
Disable azure developer cli creds (dotnet#4347) (dotnet#4350)
3f0c4a4 
Co-authored-by: Wiktor Kopec <wiktork@microsoft.com>
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
80df1dd 
…230505.1 (dotnet#4366)

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.5.23228.7 -> To Version 8.0.100-preview.4.23255.1

Dependency coherency updates

Microsoft.AspNetCore.App.Runtime.win-x64,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0
 From Version 8.0.0-preview.5.23226.1 -> To Version 8.0.0-preview.4.23251.12 (parent: Microsoft.Dotnet.Sdk.Internal

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@dotnet-maestro
[release/8.x] Update dependencies from dotnet/installer (dotnet#4390)
8ea1df2 
* Update dependencies from https://github.com/dotnet/installer build 20230509.14

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.4.23255.1 -> To Version 8.0.100-preview.4.23259.14

Dependency coherency updates

Microsoft.AspNetCore.App.Runtime.win-x64,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0
 From Version 8.0.0-preview.4.23251.12 -> To Version 8.0.0-preview.4.23259.2 (parent: Microsoft.Dotnet.Sdk.Internal

* Update dependencies from https://github.com/dotnet/installer build 20230510.5

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.4.23255.1 -> To Version 8.0.100-preview.4.23260.5

Dependency coherency updates

Microsoft.AspNetCore.App.Runtime.win-x64,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0
 From Version 8.0.0-preview.4.23251.12 -> To Version 8.0.0-preview.4.23260.4 (parent: Microsoft.Dotnet.Sdk.Internal

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@schmittjoseph
Update generate-release-notes.yml (dotnet#4418)
3761763
@jander-msft
Merge branch 'main' of https://github.com/dotnet/dotnet-monitor into …
d7debd4 
…release/8.x
@jander-msft
Merge main to release/8.x (dotnet#4493)
9b0b058
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
6300219 
…230531.8 (dotnet#4499)

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.5.23271.2 -> To Version 8.0.100-preview.5.23281.8

Dependency coherency updates

Microsoft.AspNetCore.App.Runtime.win-x64,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0
 From Version 8.0.0-preview.5.23268.15 -> To Version 8.0.0-preview.5.23281.1 (parent: Microsoft.Dotnet.Sdk.Internal

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@dotnet-maestro
Update dependencies from https://github.com/dotnet/installer build 20…
7fdd401 
…230603.2 (dotnet#4533)

Microsoft.Dotnet.Sdk.Internal
 From Version 8.0.100-preview.5.23281.8 -> To Version 8.0.100-preview.5.23303.2

Dependency coherency updates

Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0
 From Version 8.0.0-preview.5.23281.1 -> To Version 8.0.0-preview.5.23302.2 (parent: Microsoft.Dotnet.Sdk.Internal

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@jander-msft
Stable version file and link (dotnet#4553)
9e0e336
@kkeirstead
Switched to using AggregatePercentilePayload.
5768b79
@kkeirstead
Changes to AggregatePercentilePayload
684c3a5
@kkeirstead
Bringing in Shared metrics support.
ad4af5c
@kkeirstead
Updated live metrics test.
33717bc
@kkeirstead
Merged with main.
70d4c64
@kkeirstead
Fix BlobGroupBuildQuality that didn't merge correctly.
35f2784
@kkeirstead kkeirstead mentioned this pull request Sep 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kkeirstead @wiktork @jander-msft @schmittjoseph