Skip to content

fix(summary.sim): obtain confint length correctly#20

Merged
kkholst merged 5 commits intokkholst:developfrom
benesom:fix/sim-default-length-benesom
Apr 14, 2026
Merged

fix(summary.sim): obtain confint length correctly#20
kkholst merged 5 commits intokkholst:developfrom
benesom:fix/sim-default-length-benesom

Conversation

@benesom
Copy link
Copy Markdown
Collaborator

@benesom benesom commented Apr 14, 2026

No description provided.

Comment thread R/sim.default.R Outdated
mean(
abs(
object[,confint[2*i]] - object[,confint[2*(i-1)+1]]
)[[1]]
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix is [[1]], which is required to obtain a vector such that mean() works as expected.

@benesom benesom changed the title fix(sim.default): obtain confint length correctly fix(summary.sim): obtain confint length correctly Apr 14, 2026
Benedikt Sommer added 3 commits April 14, 2026 10:47
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.56%. Comparing base (8b2d650) to head (25dfe35).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
R/sim.default.R 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #20      +/-   ##
===========================================
+ Coverage    73.54%   73.56%   +0.01%     
===========================================
  Files          164      164              
  Lines        15209    15216       +7     
===========================================
+ Hits         11186    11193       +7     
  Misses        4023     4023              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kkholst kkholst merged commit 47660a0 into kkholst:develop Apr 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants