Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion R/sim.default.R
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ sim.default <- function(x = NULL, R = 100, f = NULL,
# `par.index`: list for storing position of estimate, se, confint when
# the returned simulation object is an `estimate` object
par.index <- list()
seed_sequence <- NULL
res <- val <- NULL
on.exit({
if (is.null(colnames) && !is.null(val)) {
Expand All @@ -134,6 +135,7 @@ sim.default <- function(x = NULL, R = 100, f = NULL,
class(res) <- c("sim", cls)
attr(res, "time") <- proc.time() - stm + oldtm
attr(res, "par.index") <- par.index
attr(res, "seeds") <- seed_sequence
return(res)
})
if (inherits(R, c("matrix", "data.frame")) || length(R) > 1) {
Expand All @@ -156,6 +158,9 @@ sim.default <- function(x = NULL, R = 100, f = NULL,
repl <- NROW(parval)
pb <- progressr::progressor(steps = repl)
robx <- function(iter__, ...) {
rng_seed <- if (exists(".Random.seed", envir = .GlobalEnv, inherits = FALSE))
get(".Random.seed", envir = .GlobalEnv)
else NULL
if (!is.null(progressr.message)) {
pb(message = progressr.message(...))
} else {
Expand All @@ -176,7 +181,7 @@ sim.default <- function(x = NULL, R = 100, f = NULL,
}
names(res) <- nam
}
return(structure(res, "estimate" = is_estimate))
return(structure(res, "estimate" = is_estimate, ".rng_seed" = rng_seed))
}
if (iter || !is.data.frame(parval)) {
formals(robx)[[1]] <- NULL
Expand Down Expand Up @@ -213,6 +218,11 @@ sim.default <- function(x = NULL, R = 100, f = NULL,
} else {
val <- do.call(future.apply::future_mapply, pp)
}
seed_sequence <- lapply(val, attr, ".rng_seed")
val <- lapply(val, function(v) {
attr(v, ".rng_seed") <- NULL
v
})
res <- do.call(rbind, val)
if (is.null(res)) {
res <- matrix(NA, ncol=length(val[[1]]), nrow=repl)
Expand Down
41 changes: 41 additions & 0 deletions tests/testthat/test-simdef.R
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,47 @@ test_that("sim.default with estimate objects", {
expect_equivalent(s["SD",], c(sd(res[,"a"]), sd(res[,"b"])))
})

test_that("sim.default exports seed sequences as attribute", {
foo <- function() runif(1)
future::plan("sequential")
result <- sim(foo, R = 5, future.seed = 42L)
seeds <- attr(result, "seeds")

expect_true(is.list(seeds))
expect_equal(length(seeds), 5L)
expect_true(is.integer(seeds[[1]]))
})

test_that("sim.default exported seeds reproduce results (sequential)", {
foo <- function() runif(1)
future::plan("sequential")
result <- sim(foo, R = 5, future.seed = 42L)
seeds <- attr(result, "seeds")

old_seed <- get(".Random.seed", envir = .GlobalEnv)
on.exit(assign(".Random.seed", old_seed, envir = .GlobalEnv))

for (i in seq_len(5)) {
assign(".Random.seed", seeds[[i]], envir = .GlobalEnv)
expect_equal(foo(), as.numeric(result[i, 1]))
}
})

test_that("sim.default exported seeds reproduce results (mc.cores = 1)", {
skip_on_os("windows")
foo <- function() runif(1)
result <- sim(foo, R = 5, mc.cores = 1L)
seeds <- attr(result, "seeds")

old_seed <- get(".Random.seed", envir = .GlobalEnv)
on.exit(assign(".Random.seed", old_seed, envir = .GlobalEnv))

for (i in seq_len(5)) {
assign(".Random.seed", seeds[[i]], envir = .GlobalEnv)
expect_equal(foo(), as.numeric(result[i, 1]))
}
})

test_that("sim.default subsets", {
onerun <- function(...) estimate(coef=runif(2),
vcov=diag(runif(2)),
Expand Down
Loading