feat(coef.estimate): tests for s3 method + setting options.lava(messages = 1) by default#23
Open
feat(coef.estimate): tests for s3 method + setting options.lava(messages = 1) by default#23
Conversation
benesom
changed the title
benesom
commented
Apr 24, 2026
Collaborator
Author
There was a problem hiding this comment.
@kkholst did you specificy the figure dimesions somewhere locally on your machine?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #23 +/- ##
===========================================
+ Coverage 68.77% 73.62% +4.85%
===========================================
Files 164 164
Lines 14324 15229 +905
===========================================
+ Hits 9851 11213 +1362
+ Misses 4473 4016 -457 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
benesom
commented
Apr 24, 2026
| #> a 0.5 0.3199 -0.1271 1.127 0.118111 | ||
| #> b 0.8 0.2502 0.3097 1.290 0.001384 | ||
| #> Estimate Std.Err 2.5% 97.5% P-value | ||
| #> a 0.5 0.2698 -0.02884 1.029 0.06387 |
Collaborator
Author
There was a problem hiding this comment.
@kkholst , I assume that we forgot to render the readme file during previous changes, because I don't see how the current changes would cause these estimates to change.
benesom
commented
Apr 24, 2026
| svglite, | ||
| targeted (>= 0.4), | ||
| testthat (>= 0.11), | ||
| testthat (>= 3.2.0), |
Collaborator
Author
There was a problem hiding this comment.
bump to 3.2.0 because expect_no_message() became stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R/onload.R: Explicitly initialisesmessages = 1inlava.options()on package load, ensuring the default message level is set regardless of environment. This makes the messaging behaviour predictable and testable. Also add small note about how messages can be disabled toREADME.Rmd.