npcap to work with similar behavior as WinPcap

.gitignore

@@ -7,6 +7,8 @@ PcapDotNet/src/TestResults
 PcapDotNet.DevelopersPack/3rdParty/
 artifacts/
 .vs/
+.idea/
+.vscode/
 TemporaryGeneratedFile_*
 *.cache
 *.csproj.FileListAbsolute.txt
@@ -15,6 +17,6 @@ TemporaryGeneratedFile_*
 *.pdb
 *.sdf
 *.suo
-*.vcxproj.user
+*.user
 *.db
 *.opendb

PcapDotNet/src/Directory.Build.props

@@ -16,36 +16,22 @@
     <AppendTargetFrameworkToOutputPath>True</AppendTargetFrameworkToOutputPath>
     <GenerateDocumentationFile>True</GenerateDocumentationFile>
     <IsPackable>False</IsPackable>
+    <TargetFrameworks>net40;net80</TargetFrameworks>
   </PropertyGroup>
 
   <!-- All none test projects -->
   <Choose>
     <When Condition=" !$(MSBuildProjectName.EndsWith('.Test')) ">
       <PropertyGroup>
-        <TargetFrameworks>netstandard2.0</TargetFrameworks>
         <SignAssembly>true</SignAssembly>
         <AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)PcapDotNet.snk</AssemblyOriginatorKeyFile>
       </PropertyGroup>
     </When>
-  </Choose>
-
-  <!-- All test projects -->
-  <Choose>
-    <When Condition=" $(MSBuildProjectName.EndsWith('.TestUtils')) ">
+    <Otherwise>
       <PropertyGroup>
-        <TargetFrameworks>netstandard2.0</TargetFrameworks>
         <GenerateDocumentationFile>False</GenerateDocumentationFile>
       </PropertyGroup>
-    </When>
-  </Choose>
-
-  <Choose>
-    <When Condition=" $(MSBuildProjectName.EndsWith('.Test')) ">
-      <PropertyGroup>
-        <TargetFrameworks>net48;net8.0</TargetFrameworks>
-        <GenerateDocumentationFile>False</GenerateDocumentationFile>
-      </PropertyGroup>
-    </When>
+    </Otherwise>
   </Choose>
 
 </Project>

PcapDotNet/src/PcapDotNet.Base.Test/PcapDotNet.Base.Test.csproj

@@ -2,8 +2,13 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
-    <PackageReference Include="xunit" Version="2.9.2" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="3.0.0">
+    <PackageReference Include="xunit" Version="1.9.2" Condition="'$(TargetFramework)' == 'net40'" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" Condition="'$(TargetFramework)' == 'net40'">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
+    <PackageReference Include="xunit" Version="2.9.2" Condition="'$(TargetFramework)' == 'net80'" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="3.0.0" Condition="'$(TargetFramework)' == 'net80'">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>

PcapDotNet/src/PcapDotNet.Base.Test/UInt128Tests.cs

@@ -70,7 +70,7 @@ public void CastToULongOverflow()
             }
             catch (Exception)
             {
-                Assert.Fail();
+                Assert.False(true);
                 return;
             }
             Assert.Equal(overflow, (ulong)value); 
@@ -251,4 +251,4 @@ public void ToStringTestFirstBitIsOne()
             Assert.Equal(ValueString, value.ToString("x32"));
         }
     }
-}
+}

PcapDotNet/src/PcapDotNet.Base/IListExtensions.cs

@@ -11,6 +11,7 @@ namespace PcapDotNet.Base
     public static class IListExtensions
 // ReSharper restore InconsistentNaming
     {
+#if !NET7_0_OR_GREATER
         /// <summary>
         /// Wraps a list with a ReadOnlyCollection.
         /// </summary>
@@ -21,7 +22,7 @@ public static ReadOnlyCollection<T> AsReadOnly<T>(this IList<T> list)
         {
             return new ReadOnlyCollection<T>(list);
         }
-
+#endif
         /// <summary>
         /// Returns an enumerable of all the elements in the given list starting in a specific offset and taking no more than a specific count.
         /// </summary>
@@ -37,4 +38,4 @@ public static IEnumerable<T> Range<T>(this IList<T> list, int offset, int count)
                 yield return list[i];
         }
     }
-}
+}

PcapDotNet/src/PcapDotNet.Core.Extensions/LivePacketDeviceExtensions.cs

@@ -4,6 +4,7 @@
 using System.Management;
 using System.Net.NetworkInformation;
 using Microsoft.Win32;
+using PcapDotNet.Core.Native;
 using PcapDotNet.Packets;
 using PcapDotNet.Packets.Ethernet;
 
@@ -31,6 +32,8 @@ public static string GetGuid(this LivePacketDevice livePacketDevice)
                 throw new ArgumentNullException("livePacketDevice");
 
             string livePacketDeviceName = livePacketDevice.Name;
+            if (Environment.OSVersion.Platform == PlatformID.Unix || Environment.OSVersion.Platform == PlatformID.MacOSX)
+                return livePacketDeviceName;
             if (!livePacketDeviceName.StartsWith(NamePrefix, StringComparison.Ordinal))
             {
                 throw new InvalidOperationException(string.Format(CultureInfo.InvariantCulture,
@@ -50,11 +53,14 @@ public static string GetGuid(this LivePacketDevice livePacketDevice)
         /// <exception cref="InvalidOperationException">When the PNPDeviceID cannot be retrieved from the registry.</exception>
         public static string GetPnpDeviceId(this LivePacketDevice livePacketDevice)
         {
+            if (Environment.OSVersion.Platform == PlatformID.Unix || Environment.OSVersion.Platform == PlatformID.MacOSX)
+                throw new InvalidOperationException("Platform not supported");
+
             string guid = livePacketDevice.GetGuid();
 
             using (RegistryKey key = Registry.LocalMachine.OpenSubKey(NetworkConnectionConfigKey + @"\" + guid + @"\Connection"))
             {
-                string pnpDeviceId = key.GetValue("PnpInstanceID") as string;
+                string pnpDeviceId = key?.GetValue("PnpInstanceID") as string;
                 if (pnpDeviceId == null)
                     throw new InvalidOperationException("Could not find PNP Device ID in the registry");
                 return pnpDeviceId;
@@ -75,7 +81,7 @@ public static NetworkInterface GetNetworkInterface(this LivePacketDevice livePac
                 throw new ArgumentNullException("livePacketDevice");
 
             string guid = GetGuid(livePacketDevice);
-            return NetworkInterface.GetAllNetworkInterfaces().FirstOrDefault(networkInterface => networkInterface.Id == guid);
+            return Interop.Pcap.GetAllNetworkInterfacesByDotNet().FirstOrDefault(networkInterface => networkInterface.Id == guid);
         }
 
         /// <summary>
@@ -95,6 +101,12 @@ public static MacAddress GetMacAddress(this LivePacketDevice livePacketDevice)
                 return new MacAddress(addressBytes.ReadUInt48(0, Endianity.Big));
             }
 
+            if (Environment.OSVersion.Platform != PlatformID.Unix && Environment.OSVersion.Platform != PlatformID.MacOSX
+                && livePacketDevice.Name == "rpcap://\\Device\\NPF_Loopback")
+            {
+                return new MacAddress();
+            }
+
             return livePacketDevice.GetMacAddressWmi();
         }
 
@@ -107,6 +119,9 @@ public static MacAddress GetMacAddress(this LivePacketDevice livePacketDevice)
         /// <exception cref="InvalidOperationException">When the <see cref="MacAddress"/> cannot be retrieved using WMI.</exception>
         private static MacAddress GetMacAddressWmi(this LivePacketDevice livePacketDevice)
         {
+            if (Environment.OSVersion.Platform == PlatformID.Unix || Environment.OSVersion.Platform == PlatformID.MacOSX)
+                throw new InvalidOperationException("No MAC Address on device: " + livePacketDevice.Name);
+
             string pnpDeviceId = livePacketDevice.GetPnpDeviceId();
             string escapedPnpDeviceId = pnpDeviceId.Replace(@"\", @"\\");
 
@@ -128,4 +143,4 @@ private static MacAddress GetMacAddressWmi(this LivePacketDevice livePacketDevic
             throw new InvalidOperationException("No MAC Address for WMI instance with PNP Device ID: " + pnpDeviceId);
         }
     }
-}
+}

PcapDotNet/src/PcapDotNet.Core.Extensions/NetworkInterfaceExtensions.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Linq;
 using System.Net.NetworkInformation;
+using System.Runtime.InteropServices;
 
 namespace PcapDotNet.Core.Extensions
 {
@@ -21,7 +22,9 @@ public static LivePacketDevice GetLivePacketDevice(this NetworkInterface network
             if (networkInterface == null)
                 throw new ArgumentNullException("networkInterface");
 
-            return LivePacketDevice.AllLocalMachine.FirstOrDefault(device => device.Name == LivePacketDeviceExtensions.NamePrefix + networkInterface.Id);
+            return LivePacketDevice.AllLocalMachine.FirstOrDefault(device => Environment.OSVersion.Platform == PlatformID.Unix || Environment.OSVersion.Platform == PlatformID.MacOSX
+                                                                       ? device.Name == networkInterface.Id
+                                                                       : device.Name == LivePacketDeviceExtensions.NamePrefix + networkInterface.Id);
         }
     }
-}
+}

PcapDotNet/src/PcapDotNet.Core.Extensions/PcapDotNet.Core.Extensions.csproj

@@ -7,8 +7,11 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.Win32.Registry" Version="5.0.0" />
-    <PackageReference Include="System.Management" Version="8.0.0" />
+    <Reference Include="System.Management" />
   </ItemGroup>
 
-</Project>
+  <ItemGroup>
+    <PackageReference Include="System.Management" Version="8.0.0" Condition="'$(TargetFramework)' == 'net80'" />
+  </ItemGroup>
+
+</Project>

PcapDotNet/src/PcapDotNet.Core.Extensions/TaskExtensions.cs

@@ -0,0 +1,41 @@
+using System;
+using System.Threading;
+using System.Threading.Tasks;
+
+namespace PcapDotNet.Core.Extensions
+{
+    /// <summary>
+    /// Extension methods for Task class.
+    /// </summary>
+    public static class TaskExtensions
+    {
+        /// <summary>
+        /// Creates a Task that will complete after a time delay.
+        /// </summary>
+        /// <param name="delay">The time span to wait before completing the returned Task</param>
+        /// <returns>A Task that represents the time delay</returns>
+        /// <exception cref="ArgumentOutOfRangeException">
+        /// The <paramref name="delay"/> is less than -1 or greater than the maximum allowed timer duration.
+        /// </exception>
+        /// <remarks>
+        /// After the specified time delay, the Task is completed in RanToCompletion state.
+        /// </remarks>
+        public static Task Delay(TimeSpan delay)
+        {
+            // timer inaccuracy https://github.com/dotnet/runtime/issues/100455
+#if NETCOREAPP1_0_OR_GREATER
+            return Task.Delay(delay.Add(TimeSpan.FromMilliseconds(1))); // +1 is to workaround, random return less than 1 ms too early
+#else
+            var tcs = new TaskCompletionSource<object>();
+            Timer timer = null;
+            timer = new Timer(_ =>
+                {
+                    tcs.SetResult(null);
+                    timer.Dispose(); // prevent GC
+                });
+            timer.Change((long)delay.TotalMilliseconds + 1, -1); // +1 is to workaround, random return less than 1 ms too early
+            return tcs.Task;
+#endif
+        }
+    }
+}

PcapDotNet/src/PcapDotNet.Core.Test/BerkeleyPacketFilterTests.cs

@@ -10,9 +10,15 @@ namespace PcapDotNet.Core.Test
     /// Summary description for BerkeleyPacketFilterTests
     /// </summary>
     [ExcludeFromCodeCoverage]
-    [Collection(nameof(LivePacketDeviceTests))]
     public class BerkeleyPacketFilterTests
     {
+#if !REAL
+        public BerkeleyPacketFilterTests()
+        {
+            TestablePcapPal.UseTestPal();
+        }
+#endif
+
         [Fact]
         public void BadFilterErrorTest()
         {
@@ -22,6 +28,7 @@ public void BadFilterErrorTest()
             }
         }
 
+        // fails on REAL unix because no packets are sent
         [Fact]
         public void NoCommunicatorConstructorTest()
         {
@@ -41,6 +48,7 @@ public void NoCommunicatorConstructorTest()
             }
         }
 
+        // fails on REAL unix because no packets are sent
         [Fact]
         public void NoCommunicatorConstructorWithNetmaskTest()
         {

PcapDotNet/src/PcapDotNet.Core.Test/LivePacketDeviceExtensionsTests.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Diagnostics.CodeAnalysis;
+using System.Linq;
 using PcapDotNet.Core.Extensions;
 using Xunit;
 
@@ -9,24 +10,47 @@ namespace PcapDotNet.Core.Test
     /// Summary description for LivePacketDeviceExtensionsTests
     /// </summary>
     [ExcludeFromCodeCoverage]
-    [Collection(nameof(LivePacketDeviceTests))]
     public class LivePacketDeviceExtensionsTests
     {
+#if !REAL
+        public LivePacketDeviceExtensionsTests()
+        {
+            TestablePcapPal.UseTestPal();
+        }
+#endif
+
         [Fact]
         public void GetNetworkInterfaceNullTest()
         {
             Assert.Throws<ArgumentNullException>(() => LivePacketDeviceExtensions.GetNetworkInterface(null));
         }
-
-        [Fact(Skip ="NullRefExcetion for loopback device")]
+
+        // this test tests on linux other paths!
+        [Fact]
         public void GetMacAddressTest()
         {
             foreach (LivePacketDevice device in LivePacketDevice.AllLocalMachine)
             {
-                _ = device.GetMacAddress();
+                if ((Environment.OSVersion.Platform == PlatformID.Unix || Environment.OSVersion.Platform == PlatformID.MacOSX)
+                    && (device.Name == "any" || device.Name == "bluetooth-monitor" || device.Name == "nflog"
+                        || device.Name == "nfqueue" || device.Name == "dbus-system" || device.Name == "dbus-session"))
+                {
+                    continue;
+                }
+
+                _ =  device.GetMacAddress();
             }
         }
 
+        // this test tests on linux other paths!
+        [Fact]
+        public void GetMacAddress_Loopback_ReturnsZeroMac()
+        {
+            var loopback = LivePacketDevice.AllLocalMachine.First(n => (n.Attributes & DeviceAttributes.Loopback) != 0);
+
+            Assert.Equal(Packets.Ethernet.MacAddress.Zero, loopback.GetMacAddress());
+        }
+
         [Fact]
         public void GetGuidNullDeviceTest()
         {