Skip to content

Conversation

@z1nkum
Copy link

@z1nkum z1nkum commented Dec 23, 2018

There are several cases old incident_key was not working well:

  • warning and critical rules for same alert (non-resolved incident)
  • NoData with nodata: critical

alert name + client_url looks unique enough
also we need hash because of length limit ("The maximum permitted length of this property is 255 characters" ref)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 65.0% when pulling d1fd4c3 on z1nkum:develop into c1f071e on klen:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants