feat: add getInstanceApi method to ChartPro and update related compon…#68
Open
zahidhussaina2l wants to merge 1 commit intoklinecharts:mainfrom
Open
feat: add getInstanceApi method to ChartPro and update related compon…#68zahidhussaina2l wants to merge 1 commit intoklinecharts:mainfrom
zahidhussaina2l wants to merge 1 commit intoklinecharts:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add getInstanceApi() method to expose KLineChart instance
Summary
This PR adds a new
getInstanceApi()method to theChartProinterface, allowing users to access the underlying KLineChart instance directly. This enables advanced customization and access to all native KLineChart APIs while maintaining the convenience of the ChartPro wrapper.Motivation
Currently, the KLineChartPro wrapper provides a high-level API for common operations, but users cannot access the underlying KLineChart instance for advanced use cases such as:
Changes Made
1.
src/types.tsNullableandChartfrom 'klinecharts'ChartProinterface withgetInstanceApi(): Nullable<Chart>method2.
src/ChartProComponent.tsxprops.ref()to includegetInstanceApi: () => widget3.
src/KLineChartPro.tsxChartimport from 'klinecharts'getInstanceApi()method that delegates to the chart APIUsage Example
Benefits
Nullable<Chart>return typeTesting
Breaking Changes
None. This is a non-breaking additive change.
Type Definitions
The generated type definitions correctly include the new method:
References
For available methods on the Chart instance, see KLineChart API Documentation.