Revert "Fix clippy warnings and errors"

[hzxuzhonghu]

Reverts #40

Not the reason of #40, but the #43 is super big with so many features, and has so many conflicts.

[kmesh-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from hzxuzhonghu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @hzxuzhonghu, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous change (#40) that aimed to address clippy warnings and errors. As a result, it reintroduces certain clippy warnings and undoes various code improvements related to type boxing, error handling, and explicit lifetime annotations. The changes also impact how listeners are configured and how RBAC rules are applied, shifting some error handling from Result propagation to panicking.

Highlights

• Reverted Clippy Fixes: Removed numerous #[allow(clippy::...)] attributes, re-enabling static analysis warnings across the codebase.
• Changed Error Handling: Modified several critical paths to panic on unexpected conditions (e.g., config transcoding, zero CPU count) instead of returning Result types, making the application less resilient to certain failures.
• Unboxed Data Structures: Eliminated Boxing for various data structures and enum variants, potentially altering memory allocation and ownership patterns.
• Listener and RBAC Logic Adjustments: Reverted changes to listener configuration, introducing ListenerFactory and PartialListener, and modified the application of network RBAC rules from an "any" match to an "all" match within a filter chain.
• Internal Data Representation: Updated the internal representation of Any type values from Vec<u8> to Bytes for efficiency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.