Orion Internal Sync: add orion-interner and orion-metrics crates with metrics support.#47
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @awgn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces two new Rust crates: orion-interner for efficient string interning and orion-metrics for a comprehensive metrics collection and export system. The orion-metrics crate integrates with OpenTelemetry, providing sharded counters, feature-gated metric operations, and detailed instrumentation for various system components like HTTP, TCP, TLS, and server resources.
Highlights
- New orion-interner Crate: Introduces a dedicated crate for global string interning using the
lassolibrary, optimizing memory usage for frequently repeated strings. - New orion-metrics Crate: Establishes a robust metrics framework with OpenTelemetry integration, enabling the collection and export of application performance data.
- OpenTelemetry Integration: Configures OpenTelemetry for metrics export, supporting gRPC-based OTLP endpoints and allowing configurable export periods.
- Sharded Counter Implementation: Provides
ShardedU64, a thread-safe, sharded counter mechanism usingDashMapandAtomicU64to efficiently aggregate metrics across multiple threads. - Feature-Gated Metrics: Implements feature gating (
#[cfg(feature = "metrics")]) for all metric-related code, allowing metrics to be compiled in or out based on build configuration. - Comprehensive Metric Categories: Defines and initializes a wide array of metrics across different domains, including upstream/downstream connections, HTTP requests (status codes, bytes), listener activity, server resource utilization (uptime, concurrency, memory), TCP connections, and TLS handshakes.
- Metric Macros: Introduces convenient macros (
init_observable_counter,init_observable_gauge,with_metric,with_histogram) to simplify the definition and interaction with metrics throughout the codebase.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces two new crates, orion-interner and orion-metrics, to add comprehensive metrics support using OpenTelemetry. The changes include metrics initialization, sharded counters for performance, and feature gating. The implementation is generally solid, but I've found a few critical issues, including a race condition in the sharded counter implementation and a data error in server metrics collection. I've also made some suggestions to improve code safety and clarity.
awgn
changed the title
awgn
force-pushed
the
orion-internal-sync-metrics
branch
2 times, most recently
from
2161339 to
6b376fb
Compare
Includes metrics initialization, sharded counters, and OpenTelemetry integration. Adds macros for metric operations and feature gating for metrics. Signed-off-by: Nicola Bonelli <nicola.bonelli@huawei-partners.com>
awgn
force-pushed
the
orion-internal-sync-metrics
branch
from
6b376fb to
c947eb7
Compare
Signed-off-by: Nicola Bonelli <nicola.bonelli@huawei-partners.com>
awgn
force-pushed
the
orion-internal-sync-metrics
branch
from
8784679 to
05f256f
Compare
Signed-off-by: Nicola Bonelli <nicola.bonelli@huawei-partners.com>
|
|
||
| static GLOBAL_INTERNER: OnceLock<ThreadedRodeo> = OnceLock::new(); | ||
|
|
||
| pub fn to_static_str(s: &str) -> &'static str { |
There was a problem hiding this comment.
is this worth a separate package
There was a problem hiding this comment.
And when and where is it used
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
This PR includes metrics initialization, sharded counters, and OpenTelemetry integration. Adds macros for metric operations and feature gating for metrics.