Skip to content

keep hyper_util, so we donot need to change the code once we depend o…#48

Merged
kmesh-bot merged 2 commits intokmesh-net:mainfrom
hzxuzhonghu:rvert-hyper-name
Aug 27, 2025
Merged

keep hyper_util, so we donot need to change the code once we depend o…#48
kmesh-bot merged 2 commits intokmesh-net:mainfrom
hzxuzhonghu:rvert-hyper-name

Conversation

@hzxuzhonghu
Copy link
Member

…n upstream hyper directly

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @hzxuzhonghu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the project's dependency on hyper-util. Previously, a custom or forked version named orion-hyper-util was used. This change updates the project to directly utilize the official hyper-util crate, ensuring compatibility and simplifying future maintenance by aligning with upstream developments.

Highlights

  • Dependency Management: Migrated from a custom or forked orion-hyper-util crate to directly using the upstream hyper-util crate (version 0.1.15).
  • Codebase Updates: Updated import paths and type references across multiple files to reflect the change from orion_hyper_util to hyper_util.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hzxuzhonghu
Copy link
Member Author

After #45

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the dependency management by replacing the orion-hyper-util alias with a direct dependency on hyper-util. The changes are applied consistently across all relevant Cargo.toml files and Rust source files. This is a good simplification of the project's dependencies. The changes are correct and look good.

…n upstream hyper directly

Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
@kmesh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kmesh-bot kmesh-bot merged commit 12ae446 into kmesh-net:main Aug 27, 2025
4 checks passed
@hzxuzhonghu hzxuzhonghu deleted the rvert-hyper-name branch August 27, 2025 03:45
Eeshu-Yadav pushed a commit to Eeshu-Yadav/orion that referenced this pull request Aug 27, 2025
keep hyper_util, so we donot need to change the code once we depend o…
Eeshu-Yadav pushed a commit to Eeshu-Yadav/orion that referenced this pull request Aug 28, 2025
keep hyper_util, so we donot need to change the code once we depend o…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants