replacing codeflask with code-input #2139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have some css related issue in this PR. Let me try debugging and closing this issue before this weekends. |
Bowrna
force-pushed
the
replace_codeflask
branch
from
30289d3 to
80e6dd1
Compare
|
Could this PR be reviewed? |
|
Hi @Bowrna. There seems to be several issues with this. The HTML editor is completely broken. This is what I'm getting: Referring |
|
@knadh Let me fix this and update here. I missed this. |
Et-008
reviewed
Mar 6, 2025
| this.initHTMLEditor(this.$props.value || ''); | ||
| }, | ||
|
|
||
| watch: { |
There was a problem hiding this comment.
Why is the below code being used only in markdownEditor and not in HTMLeditor?
watch: {
value(newVal) {
if (newVal !== this.data) {
this.data = newVal;
}
},
},
Bowrna
force-pushed
the
replace_codeflask
branch
from
80e6dd1 to
24d6710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #2072
This is work in progress to replace codeflask with code-input for showing syntax highlighted text/code editor inside campaign content.