fix: handle NULL list_id in campaign processing to prevent crash#2908
Open
SriHarsha-23 wants to merge 1 commit intoknadh:masterfrom
Open
fix: handle NULL list_id in campaign processing to prevent crash#2908SriHarsha-23 wants to merge 1 commit intoknadh:masterfrom
SriHarsha-23 wants to merge 1 commit intoknadh:masterfrom
Conversation
knadh
added
hodor-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes a crash that occurs when NextSubscribers encounters a NULL list_id in the runningCamp struct.
The ListID field was previously defined as int, which caused a sql: Scan error when the database returned a NULL value (e.g. from deleted lists or inconsistent states).
Changes:
Updated runningCamp struct in cmd/manager_store.go: Changed ListID type from int to sql.NullInt64.
Updated NextSubscribers: Added a check for c.ListID.Valid before appending to the list of IDs.
Related Issue:
Closes #2851