fix: ensure relative CID images load in web views - #3171
Open
joshuaboniface wants to merge 1 commit into
Open
Conversation
Previously, a relative-link CID image in a template would not render properly in the web view or archive of the message; it would use a link relative to the actual campaign URL, which did not contain the media file. This corrects that by properly resolving CID images to real media URLs during rendering, displaying these images properly.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Issues Found
No issues found.
Summary
Total issues: 0 critical, 0 important, 0 minor.
Overall Verdict
Status: Patch is correct
Explanation: The PR consistently resolves data-embed inline images to media URLs for archive and web-view rendering by adding a store lookup for media URLs and applying it before template compilation in the relevant endpoints. No production-impacting bugs were identified in the introduced diff.
Review generated by Hodor (model: gpt-5.2)
Review Metrics — 34 turns, 36 tool calls, 3m 31s
- Tokens: in
23.9K| cached438.9K| out10.6K(total473.5K) - Cost:
$0.2678
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a relative-link CID image in a template would not render properly in the web view or archive of the message; it would use a link relative to the actual campaign URL, which did not contain the media file.
This corrects that by properly resolving CID images to real media URLs during rendering, displaying these images properly.