Skip to content

fix: return apt Gone status code and error message when OTP no longer… #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drishyars wants to merge 2 commits into from
Closed

fix: return apt Gone status code and error message when OTP no longer… #54

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fc9071
fix: return apt Gone status code and error message when OTP no longer…
drishyars Feb 5, 2026
f74fd56
Merge branch 'master' into fix/otp-expiry-handling
drishyars Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions cmd/otpgateway/handlers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,15 +234,14 @@ func TestCheckOTP(t *testing.T) {

// Check it again. Should be deleted.
r = testRequest(t, http.MethodPost, "/api/otp/"+dummyOTPID, cp, &data)
assert.NotEqual(t, http.StatusOK, r.StatusCode, "OTP didn't get deleted on verification")
assert.Equal(t, http.StatusGone, r.StatusCode, "OTP didn't get deleted on verification")

// Check non-existent OTP, should not return 200.
// Check non-existent OTP, should return 410 Gone.
r = testRequest(t, http.MethodPost, "/api/otp/abc123", cp, &data)
assert.NotEqual(t, http.StatusOK, r.StatusCode, "non-existent OTP didn't return 200")
assert.Equal(t, http.StatusGone, r.StatusCode, "non-existent OTP didn't return 410")

// Check non-existent OTP, should return 410.
r = testRequest(t, http.MethodPost, "/api/otp/abc123", cp, &out)
assert.Equal(t, http.StatusGone, r.StatusCode, "non-existent OTP returns 410")
// Check non-existent OTP, should return store.ErrNotExist error message.
_ = testRequest(t, http.MethodPost, "/api/otp/abc123", cp, &out)
assert.Equal(t, "OTP has expired or doesn't exist", out.Message, "non-existent OTP passed")
}

Expand Down
Loading