Skip to content

[release-1.19] Fix ignored DISPATCHERS_MIN_REPLICAS environment variable. #4565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-1.18
Choose a base branch
from
Open

[release-1.19] Fix ignored DISPATCHERS_MIN_REPLICAS environment variable. #4565

wants to merge 1 commit into from

Conversation

@twoGiants
Copy link
Contributor

This is a manual cherry-pick of #4555

The DISPATCHERS_MIN_REPLICAS environment variable can now be used to control the dispatcher replicas

@twoGiants
Fix ignored DISPATCHERS_MIN_REPLICAS env var. (knative-extensions#4555
1ce363d 
)

Add MinReplicas to copied config in `createKafkaScheduler`. Cover bug with
test and clean up the code a little. Extract duplicated code into function
and replace strings with existing constants.

Issue knative-extensions#4542.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
@knative-prow knative-prow bot added area/control-plane size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 24, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: twoGiants
Once this PR has been reviewed and has the lgtm label, please assign aliok for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from aliok and creydr October 24, 2025 14:44
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 29.68%. Comparing base (df474c0) to head (1ce363d).
⚠️ Report is 1 commits behind head on release-1.18.

Files with missing lines Patch % Lines
...l-plane/pkg/reconciler/consumergroup/controller.go 25.00% 3 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.18    #4565   +/-   ##
=============================================
  Coverage         29.67%   29.68%           
=============================================
  Files               290      290           
  Lines             15415    15416    +1     
=============================================
+ Hits               4575     4576    +1     
  Misses            10386    10386           
  Partials            454      454

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@twoGiants
Copy link
Contributor Author

/retest-required

@dprotaso
Copy link
Contributor

Do we want to close #4557 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aliok aliok Awaiting requested review from aliok

@creydr creydr Awaiting requested review from creydr

Assignees

No one assigned

Labels

area/control-plane size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twoGiants @dprotaso