Skip to content

Conversation

@astelmashenko
Copy link
Member

@astelmashenko astelmashenko commented Jan 20, 2026

A custom broker implementation consists of few components:

  1. Feature/natsjs broker step1 #715 broker controller, to be able to specify NatsJetstreamBroker class for a broker CRD
  2. added trigger controller and reconciler #716 trigger controller, to receive events for eventing triggers which are subscribed to the NatsJetstreamBroker class and reconcile subscriptions to JetStream
  3. custom broker ingress #719 ingress, which accepts http requests to broker and stores it into JetStream stream storage
  4. filter, which creates consumers to JetStream, get messages, filter them out and sends to targets according to triggers configuration
  5. configuration is a set of yaml files describe CRD, service accounts, roles and permissions of above components
  6. e2e tests/docs/examples

TODO: add description

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2026
@knative-prow knative-prow bot requested review from Cali0707 and aliok January 20, 2026 10:08
@astelmashenko astelmashenko removed the request for review from aliok January 20, 2026 10:08
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 20, 2026
@astelmashenko astelmashenko removed the request for review from Cali0707 January 20, 2026 10:08
@knative-prow
Copy link

knative-prow bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astelmashenko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 4.87805% with 468 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.26%. Comparing base (e77ad31) to head (24f16e2).

Files with missing lines Patch % Lines
pkg/broker/filter/consumer.go 0.00% 147 Missing ⚠️
pkg/broker/filter/handler.go 14.81% 138 Missing ⚠️
pkg/broker/filter/controller.go 0.00% 88 Missing ⚠️
pkg/broker/filter/reconciler.go 0.00% 65 Missing ⚠️
pkg/common/nats/conn.go 0.00% 23 Missing ⚠️
cmd/filter/main.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
- Coverage   30.81%   27.26%   -3.55%     
==========================================
  Files          53       58       +5     
  Lines        3096     3587     +491     
==========================================
+ Hits          954      978      +24     
- Misses       2074     2541     +467     
  Partials       68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant