Added support to configure listener ip addresses with comma separated list of IPs (ex: "0.0.0.0,::")

[agallegoz]

Changes

• Added new configmap param "listen-ip-addresses" to configure the list of IP address to listen to (ex: "0.0.0.0,::") for listening IPv4 and IPv6. Default behaviour is "0.0.0.0" to keep backward compatibility
• Added tests for new functionality
• Modified previous tests to include the new arguments

/kind enhancement

Fixes #1299

Release Note

Add ability to set a list of listening IP addresses. This enables the usage of kourier in clusters with IPv4 and IPv6.

Docs

It is a continuation of this stalled pull request

[knative-prow]

@agallegoz: The label(s) kind/<kind>enhancement cannot be applied, because the repository doesn't have them.

In response to this:

Changes

• Added new configmap param "listen-ip-addresses" to configure the list of IP address to listen to (ex: "0.0.0.0,::") for listening IPv4 and IPv6. Default behaviour is "0.0.0.0" to keep backward compatibility
• Added tests for new functionality
• Modified previous tests to include the new arguments

/kind enhancement

Fixes #1299

Release Note

Add ability to set a list of listening IP addresses. This enables the usage of kourier in clusters with IPv4 and IPv6.

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: agallegoz / name: agallego (84cd509, b1ed296)
• ✅ login: agallegoz / name: agallegoz (bf7e155)

[knative-prow]

Welcome @agallegoz! It looks like this is your first PR to knative-extensions/net-kourier 🎉

[knative-prow]

Hi @agallegoz. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[agallegoz]

@skonto I try to push this topic forward, as this pull request seems inactive.

[agallegoz]

/ok-to-test

[knative-prow]

@agallegoz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

❌ Patch coverage is 68.42105% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.08%. Comparing base (42bed47) to head (84cd509).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/envoy/api/listener.go	70.00%	9 Missing and 3 partials ⚠️
pkg/reconciler/ingress/config/kourier.go	45.45%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
- Coverage   72.46%   72.08%   -0.38%     
==========================================
  Files          25       25              
  Lines        2099     2135      +36     
==========================================
+ Hits         1521     1539      +18     
- Misses        486      500      +14     
- Partials       92       96       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[agallegoz]

Fixed fmt and lint errors. Can you run the test workflow again?

[agallegoz]

@dsimansk @skonto gently ping

[agallegoz]

@dsimansk @skonto another gently ping

[dprotaso]

/ok-to-test

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: agallegoz
Once this PR has been reviewed and has the lgtm label, please ask for approval from dsimansk. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[agallegoz]

/retest-required

[knative-prow]

@agallegoz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
build-tests_net-kourier_main	bf7e155	link	true	/test build-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[agallegoz]

@dprotaso I think that the errors of build-tests are not mine, the check license is not modified by my changes, and if I download upstream main branch and run the tests without my changes I got the same errors, so I think that the problem with build test is an existing problem in upstream main branch:

--- FAIL: go-licenses failed the license check

You can check by downloading the main branch and executing ./hack/update-codegen.sh and you will get the same error.

Thank you!