Used Port 0 to fix issue #7393

pkg/adapter/mtping/runner_test.go

@@ -213,7 +213,7 @@ func TestSendEventsTLS(t *testing.T) {
 	eventsChan := make(chan cloudevents.Event, 10)
 	handler := eventingtlstesting.EventChannelHandler(eventsChan)
 	events := make([]cloudevents.Event, 0, 8)
-	ca := eventingtlstesting.StartServer(ctx, t, 8500, handler)
+	ca, _ := eventingtlstesting.StartServer(ctx, t, 8500, handler)
 	hostString := "localhost:8500"
 
 	var wg sync.WaitGroup

pkg/adapter/v2/cloudevents_test.go

@@ -309,7 +309,7 @@ func TestTLS(t *testing.T) {
 	ctx, cancel := context.WithCancel(ctx)
 	t.Cleanup(cancel)
 
-	ca := eventingtlstesting.StartServer(ctx, t, 8333, nethttp.HandlerFunc(func(writer nethttp.ResponseWriter, request *nethttp.Request) {
+	ca, _ := eventingtlstesting.StartServer(ctx, t, 8333, nethttp.HandlerFunc(func(writer nethttp.ResponseWriter, request *nethttp.Request) {
 		if request.TLS == nil {
 			// It's not on TLS, fail request
 			writer.WriteHeader(nethttp.StatusInternalServerError)

pkg/eventingtls/eventingtlstesting/eventingtlstesting.go

@@ -47,7 +47,7 @@ func init() {
 	CA, Key, Crt = loadCerts()
 }
 
-func StartServer(ctx context.Context, t *testing.T, port int, handler http.Handler, receiverOptions ...kncloudevents.HTTPEventReceiverOption) string {
+func StartServer(ctx context.Context, t *testing.T, port int, handler http.Handler, receiverOptions ...kncloudevents.HTTPEventReceiverOption) (string, int) {
 	secret := types.NamespacedName{
 		Namespace: "knative-tests",
 		Name:      "tls-secret",
@@ -83,7 +83,8 @@ func StartServer(ctx context.Context, t *testing.T, port int, handler http.Handl
 		}
 	}()
 
-	return string(CA)
+	// Return the CA certificate and assigned port
+	return string(CA), port
 }
 
 func loadCerts() ([]byte, []byte, []byte) {

pkg/kncloudevents/event_dispatcher_test.go

@@ -20,6 +20,7 @@ import (
 	"bytes"
 	"context"
 	"encoding/base64"
+	"fmt"
 	"io"
 	"net/http"
 	"net/http/httptest"
@@ -928,28 +929,38 @@ func TestSendEvent(t *testing.T) {
 }
 
 func TestDispatchMessageToTLSEndpoint(t *testing.T) {
+	// Initialize wait group and context
 	var wg sync.WaitGroup
 	ctx, _ := rectesting.SetupFakeContext(t)
 	ctx, cancel := context.WithCancel(ctx)
 	defer func() {
 		cancel()
-		// give the servers a bit time to fully shutdown to prevent port clashes
+		// give the servers a bit of time to fully shut down to prevent port clashes
 		time.Sleep(500 * time.Millisecond)
 	}()
+	// Initialize OIDC token provider and dispatcher
 	oidcTokenProvider := auth.NewOIDCTokenProvider(ctx)
 	dispatcher := kncloudevents.NewDispatcher(eventingtls.NewDefaultClientConfig(), oidcTokenProvider)
+	// Create a full event for testing
 	eventToSend := test.FullEvent()
 
 	// destination
 	destinationEventsChan := make(chan cloudevents.Event, 10)
 	destinationReceivedEvents := make([]cloudevents.Event, 0, 10)
-	destinationHandler := eventingtlstesting.EventChannelHandler(destinationEventsChan)
-	destinationCA := eventingtlstesting.StartServer(ctx, t, 8334, destinationHandler, kncloudevents.WithDrainQuietPeriod(time.Millisecond))
+
+	// Mock destinationHandler
+	destinationHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		// Implement your custom handler logic here
+	})
+
+	// Use the updated StartServer function to get CA certificate and assigned port
+	destinationCA, port := eventingtlstesting.StartServer(ctx, t, 0, destinationHandler, kncloudevents.WithDrainQuietPeriod(time.Millisecond))
 	destination := duckv1.Addressable{
-		URL:     apis.HTTPS("localhost:8334"),
+		URL:     apis.HTTPS(fmt.Sprintf("localhost:%d", port)),
 		CACerts: &destinationCA,
 	}
 
+	// Start goroutine to receive events
 	wg.Add(1)
 	go func() {
 		defer wg.Done()
@@ -958,16 +969,17 @@ func TestDispatchMessageToTLSEndpoint(t *testing.T) {
 		}
 	}()
 
-	// send event
+	// Send event
 	message := binding.ToMessage(&eventToSend)
 	info, err := dispatcher.SendMessage(ctx, message, destination)
 	require.Nil(t, err)
 	require.Equal(t, 200, info.ResponseCode)
 
-	// check received events
+	// Check received events
 	close(destinationEventsChan)
 	wg.Wait()
 
+	// Assertions on received events
 	require.Len(t, destinationReceivedEvents, 1)
 	require.Equal(t, eventToSend.ID(), destinationReceivedEvents[0].ID())
 	require.Equal(t, eventToSend.Data(), destinationReceivedEvents[0].Data())
@@ -999,7 +1011,7 @@ func TestDispatchMessageToTLSEndpointWithReply(t *testing.T) {
 		w.Write(eventToReply.Data())
 	})
 
-	destinationCA := eventingtlstesting.StartServer(ctxDestination, t, 8334, destinationHandler, kncloudevents.WithDrainQuietPeriod(time.Millisecond))
+	destinationCA, _ := eventingtlstesting.StartServer(ctxDestination, t, 8334, destinationHandler, kncloudevents.WithDrainQuietPeriod(time.Millisecond))
 	destination := duckv1.Addressable{
 		URL:     apis.HTTPS("localhost:8334"),
 		CACerts: &destinationCA,
@@ -1009,7 +1021,7 @@ func TestDispatchMessageToTLSEndpointWithReply(t *testing.T) {
 	replyEventChan := make(chan cloudevents.Event, 10)
 	replyHandler := eventingtlstesting.EventChannelHandler(replyEventChan)
 	replyReceivedEvents := make([]cloudevents.Event, 0, 10)
-	replyCA := eventingtlstesting.StartServer(ctxReply, t, 8335, replyHandler, kncloudevents.WithDrainQuietPeriod(time.Millisecond))
+	replyCA, _ := eventingtlstesting.StartServer(ctxReply, t, 8335, replyHandler, kncloudevents.WithDrainQuietPeriod(time.Millisecond))
 	reply := duckv1.Addressable{
 		URL:     apis.HTTPS("localhost:8335"),
 		CACerts: &replyCA,
@@ -1059,7 +1071,7 @@ func TestDispatchMessageToTLSEndpointWithDeadLetterSink(t *testing.T) {
 		w.WriteHeader(http.StatusInternalServerError)
 	})
 
-	destinationCA := eventingtlstesting.StartServer(ctxDestination, t, 8334, destinationHandler, kncloudevents.WithDrainQuietPeriod(time.Millisecond))
+	destinationCA, _ := eventingtlstesting.StartServer(ctxDestination, t, 8334, destinationHandler, kncloudevents.WithDrainQuietPeriod(time.Millisecond))
 	destination := duckv1.Addressable{
 		URL:     apis.HTTPS("localhost:8334"),
 		CACerts: &destinationCA,
@@ -1069,7 +1081,7 @@ func TestDispatchMessageToTLSEndpointWithDeadLetterSink(t *testing.T) {
 	dlsEventChan := make(chan cloudevents.Event, 10)
 	dlsHandler := eventingtlstesting.EventChannelHandler(dlsEventChan)
 	dlsReceivedEvents := make([]cloudevents.Event, 0, 10)
-	dlsCA := eventingtlstesting.StartServer(ctxDls, t, 8335, dlsHandler, kncloudevents.WithDrainQuietPeriod(time.Millisecond))
+	dlsCA, _ := eventingtlstesting.StartServer(ctxDls, t, 8335, dlsHandler, kncloudevents.WithDrainQuietPeriod(time.Millisecond))
 	dls := duckv1.Addressable{
 		URL:     apis.HTTPS("localhost:8335"),
 		CACerts: &dlsCA,