Skip to content

Conversation

@intojhanurag
Copy link

Changes Include

  • Added environment variable (e.g., REQUEST_REPLY_TIMEOUT) to control the per-request timeout duration.
  • Updated IngressHandler to read the timeout from the environment; defaults to 1 minute if unset or invalid.

@knative-prow
Copy link

knative-prow bot commented Nov 3, 2025

Welcome @intojhanurag! It looks like this is your first PR to knative/eventing 🎉

@knative-prow
Copy link

knative-prow bot commented Nov 3, 2025

Hi @intojhanurag. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: intojhanurag
Once this PR has been reviewed and has the lgtm label, please assign pierdipi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from Leo6Leo and aliok November 3, 2025 18:49
@intojhanurag
Copy link
Author

Hey @aliok , Can you take a look if you have a moment ?

@intojhanurag
Copy link
Author

Hey @Cali0707 , Please can you take a look on this one.

@Cali0707
Copy link
Member

Cali0707 commented Nov 4, 2025

Hey @intojhanurag this should not be configured by env variable - it should be coming from the api type for the specific request reply that is handling the specific request (see here:

Timeout *string `json:"timeout,omitempty"`
)

In general, it is great to open issues before going through with opening a PR as it lets us discuss what the correct fix is before you spend time on implementing it

@intojhanurag
Copy link
Author

intojhanurag commented Nov 4, 2025

Hey @Cali0707 , Thanks for the guidance ! I will take care of it . Your blog was also so informative for me (Specially that custom git command blog 😀)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants