Skip to content

added PodSecurityContext #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

added PodSecurityContext #2174

wants to merge 3 commits into from

Conversation

Sanket-0510
Copy link
Contributor

Changes

Schema for PodSecurityContext so that users can define fields like fsGroup

/kind Enhancement

Fixes #2108

@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 20, 2024

Hi @Sanket-0510. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2024
@matejvasek matejvasek requested review from a team and lkingland and removed request for maximilien and jrangelramos February 21, 2024 02:08
@lkingland
Copy link
Member

I am grateful for this contribution.
Could we please run gofmt on the files? there's a few formatting problems that are causing our linters to complain.

lkingland
lkingland reviewed Mar 29, 2024
View reviewed changes
schema/func_yaml-schema.json
@@ -16,7 +16,7 @@
}
},
"type": "object",
"description": "BuilderImages define optional explicit builder images to use by\nbuilder implementations in leau of the in-code defaults. They key\nis the builder's short name. For example:\nbuilderImages:\n pack: example.com/user/my-pack-node-builder\n s2i: example.com/user/my-s2i-node-builder"
"description// with containerized docker runner and deployed Knative service integration": "BuilderImages define optional explicit builder images to use by\nbuilder implementations in leau of the in-code defaults. They key\nis the builder's short name. For example:\nbuilderImages:\n pack: example.com/user/my-pack-node-builder\n s2i: example.com/user/my-s2i-node-builder"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit odd?

@github-actions GitHub Actions
Copy link
Contributor

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2024
@github-actions github-actions bot closed this Jul 29, 2024
@lkingland
Copy link
Member

This PR is in the right ballpark. Can we get the code formatted with gofmt and then we can have a discussion about the implementation itself?

@lkingland lkingland reopened this Feb 28, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Sanket-0510
Once this PR has been reviewed and has the lgtm label, please assign dprotaso for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lkingland lkingland removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2025
@Sanket-0510
Copy link
Contributor Author

Hey @lkingland I will do the needed and we can discuss it further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkingland lkingland lkingland left review comments

Assignees
No one assigned
Labels
kind/enhancement needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pod security context from func.yaml
2 participants
@Sanket-0510 @lkingland