feat: export TagLabelKey constant for per-tag Ingress resources#1120
Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom Mar 10, 2026
Merged
feat: export TagLabelKey constant for per-tag Ingress resources#1120knative-prow[bot] merged 1 commit intoknative:mainfrom
knative-prow[bot] merged 1 commit intoknative:mainfrom
Conversation
Add TagLabelKey to the networking API constants so that downstream consumers (e.g. serving) can reference a single canonical definition instead of duplicating the label key locally. Signed-off-by: kahirokunn <okinakahiro@gmail.com>
knative-prow
bot
added
kind/enhancement
size/XS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1120 +/- ##
=======================================
Coverage 93.33% 93.33%
=======================================
Files 35 35
Lines 1005 1005
=======================================
Hits 938 938
Misses 53 53
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, kahirokunn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TagLabelKey to the networking API constants so that downstream
consumers (e.g. serving) can reference a single canonical definition
instead of duplicating the label key locally.
Changes
TagLabelKeyconstant (networking.internal.knative.dev/tag) in the networking API constants/kind enhancement
Release Note
Docs