Skip to content

Fix webhook admission control deadlock during installation #3620

Fix webhook admission control deadlock during installation

Fix webhook admission control deadlock during installation #3620

Triggered via pull request October 22, 2025 22:11
Status Failure
Total duration 3m 0s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
4s
style / changes
style  /  ...  /  Auto-format and Check
26s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
2m 38s
style / Golang / Lint
style  /  ...  /  Do Not Submit
10s
style / Golang / Do Not Submit
style  /  ...  /  shell
0s
style / suggester / shell
style  /  ...  /  yaml
0s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 4 warnings
style / Golang / Auto-format and Check
Process completed with exit code 1.
style / Golang / Auto-format and Check: pkg/reconciler/knativeserving/knativeserving.go#L0
Please run goimports. diff --git a/pkg/reconciler/knativeserving/knativeserving.go b/pkg/reconciler/knativeserving/knativeserving.go index 7196357..815e032 100644 --- a/pkg/reconciler/knativeserving/knativeserving.go +++ b/pkg/reconciler/knativeserving/knativeserving.go @@ -124,7 +124,7 @@ func (r *Reconciler) ReconcileKind(ctx context.Context, ks *v1beta1.KnativeServi r.appendExtensionManifests, r.transform, manifests.Install, - manifests.SetManifestPaths, // setting path right after applying manifests to populate paths + manifests.SetManifestPaths, // setting path right after applying manifests to populate paths common.CheckWebhookDeployment, // Wait for webhook to be ready before creating Certificate resources common.InstallWebhookDependentResources, common.CheckDeployments,
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/operator/operator. Supported file pattern: go.sum
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/operator/operator. Supported file pattern: go.sum
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/operator/operator. Supported file pattern: go.sum
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/operator/operator. Supported file pattern: go.sum