Skip to content

[trivial] strip \t in single-line descriptions #2190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

[trivial] strip \t in single-line descriptions #2190

merged 1 commit into from
Oct 31, 2025

Conversation

@penguinolog
Copy link
Contributor

Make helm generated template parseable with python.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 31, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: penguinolog / name: Aleksei Stepanov (92b30b3)

@knative-prow
Copy link

knative-prow bot commented Oct 31, 2025

Welcome @penguinolog! It looks like this is your first PR to knative/operator 🎉

@knative-prow
Copy link

knative-prow bot commented Oct 31, 2025

Hi @penguinolog. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2025
@knative-prow knative-prow bot requested review from houshengbo and matzew October 31, 2025 13:18
@penguinolog
[trivial] strip \t in single-line descriptions
92b30b3 
Make helm generated template parseable with python
penguinolog
penguinolog commented Oct 31, 2025
View reviewed changes
config/charts/knative-operator/templates/operator.yaml
anyOf:
- type: integer
- type: string
description: An eviction is allowed if at most "maxUnavailable" pods selected by "selector" are unavailable after the eviction, i.e. even in absence of the evicted pod. For example, one can prevent all voluntary evictions by specifying 0. This is a mutually exclusive setting with "minAvailable".
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this visually not visible \t breaking parse of helm template output with ruamel.yaml and pyyaml libraries

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2025
@houshengbo
Copy link
Contributor

/ok-to-test
/lgtm
/approve

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, penguinolog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 0423300 into knative:main Oct 31, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houshengbo houshengbo houshengbo approved these changes

@matzew matzew Awaiting requested review from matzew

Assignees

@houshengbo houshengbo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@penguinolog @houshengbo