Skip to content

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Nov 3, 2025

Unclear why go linter is complaining about this now (#3286)

I ran golangci-lint run --fix

@knative-prow
Copy link

knative-prow bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2025
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 3, 2025
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.58%. Comparing base (c5e9118) to head (f2c915d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
webhook/certificates/resources/certs.go 33.33% 2 Missing ⚠️
signals/signal.go 0.00% 1 Missing ⚠️
...ook/resourcesemantics/conversion/internal/types.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3287   +/-   ##
=======================================
  Coverage   74.58%   74.58%           
=======================================
  Files         188      188           
  Lines        8184     8184           
=======================================
  Hits         6104     6104           
  Misses       1840     1840           
  Partials      240      240           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nader-ziada
Copy link
Member

/lgtm

I'm surprised it didn't complain about these before

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
@knative-prow knative-prow bot merged commit a440059 into knative:main Nov 3, 2025
37 checks passed
@dprotaso dprotaso deleted the gofmpt branch November 3, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants