Skip to content

Conversation

@linkvt
Copy link
Contributor

@linkvt linkvt commented Nov 18, 2025

Fixes #15981

Proposed Changes

  • Fix error handling in request log template execution
    • Add missing return statement after template execution error to prevent writing partial buffer contents after the error message has been logged.

Release Note

Fix request log output corruption when using invalid log templates

Add missing return statement after template execution error to prevent
writing partial buffer contents after the error message has been logged.
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2025
@knative-prow knative-prow bot requested review from dsimansk and skonto November 18, 2025 17:39
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.01%. Comparing base (c46db77) to head (728d64a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16242      +/-   ##
==========================================
- Coverage   80.02%   80.01%   -0.01%     
==========================================
  Files         214      214              
  Lines       13317    13318       +1     
==========================================
  Hits        10657    10657              
- Misses       2298     2300       +2     
+ Partials      362      361       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, linkvt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2025
@knative-prow knative-prow bot merged commit fd49d7a into knative:main Nov 18, 2025
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

queue-proxy:Invalid request log template

2 participants