feat: support org secrets #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedder
reviewed
Oct 21, 2021
| RUN pip3 install -r requirements.txt | ||
|
|
||
| CMD [ "python", "/app/rotate_keys.py" ] | ||
| CMD [ "python", "/app/rotate_keys.py" ] |
Contributor
There was a problem hiding this comment.
as good practice you shouldn't commit whitespace-only changes to files. I'm a believer in "newline at EOF" but it's not good to have random changes like this.
tedder
reviewed
Oct 21, 2021
| (public_key, pub_key_id) = get_org_pub_key(repo, github_token) | ||
|
|
||
| # encrypt the secrets | ||
| encrypted_access_key = encrypt(public_key, new_access_key) |
Contributor
There was a problem hiding this comment.
this conditional creates a LOT of duplicated code. only one line is different between the branches.
tedder
reviewed
Oct 21, 2021
| return (public_key, public_key_id) | ||
|
|
||
| def upload_secret(owner_repo,key_name,encrypted_value,pub_key_id,github_token): | ||
| def get_org_pub_key(org, github_token): |
Contributor
There was a problem hiding this comment.
there's a way to refactor this to reduce the duplicated code, but it's not as easy as the conditional above. (the trick would be to use optional arguments for owner_repo and org).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.