Skip to content
This repository was archived by the owner on Jun 26, 2026. It is now read-only.

Unset draining after we are drained#4

Open
nullstyle wants to merge 1 commit into
knex:masterfrom
nullstyle:master
Open

Unset draining after we are drained#4
nullstyle wants to merge 1 commit into
knex:masterfrom
nullstyle:master

Conversation

@nullstyle

Copy link
Copy Markdown

No description provided.

@elliotf

elliotf commented Nov 21, 2014

Copy link
Copy Markdown

This doesn't seem to address the problem of bookshelf/knex having issues with disconnected DB connections. This change seems to only impact the caller when .drain() is called. Without this change, you need to create a new generic pool (which knex does) .. With this change, you could reuse a pool.

Is that what you were trying to achieve, @nullstyle ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants