refactor: consistent line breaks in generated files. - #59
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 13 13
Lines 3859 3860 +1
Branches 681 681
=======================================
+ Hits 3557 3558 +1
Misses 275 275
Partials 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the line break handling in generated TypeScript files to ensure consistent formatting. The main change is to the formatSelectorModuleSource function which generates .knighted-css.ts files.
Changes:
- Refactored line break logic in generated files to use consistent double-newline separation between sections
- Added
precheck-typesscript to ensure type generation before type checking - Bumped package version to 1.1.0-rc.2
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/css/src/generateTypes.ts | Refactored formatSelectorModuleSource to use sections array with consistent line break handling |
| packages/playwright/package.json | Added precheck-types script that runs npm run types before type checking |
| packages/css/package.json | Version bumped from 1.1.0-rc.1 to 1.1.0-rc.2 |
| package-lock.json | Updated version references and added node_modules entry for @knighted/css in playwright package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.