Skip to content

refactor: consistent line breaks in generated files. - #59

Merged
knightedcodemonkey merged 3 commits into
mainfrom
bananas
Jan 17, 2026
Merged

refactor: consistent line breaks in generated files.#59
knightedcodemonkey merged 3 commits into
mainfrom
bananas

Conversation

@knightedcodemonkey

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 17, 2026 21:59
@codecov

codecov Bot commented Jan 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.17%. Comparing base (8f561c0) to head (ab1a46b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files          13       13           
  Lines        3859     3860    +1     
  Branches      681      681           
=======================================
+ Hits         3557     3558    +1     
  Misses        275      275           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the line break handling in generated TypeScript files to ensure consistent formatting. The main change is to the formatSelectorModuleSource function which generates .knighted-css.ts files.

Changes:

  • Refactored line break logic in generated files to use consistent double-newline separation between sections
  • Added precheck-types script to ensure type generation before type checking
  • Bumped package version to 1.1.0-rc.2

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
packages/css/src/generateTypes.ts Refactored formatSelectorModuleSource to use sections array with consistent line break handling
packages/playwright/package.json Added precheck-types script that runs npm run types before type checking
packages/css/package.json Version bumped from 1.1.0-rc.1 to 1.1.0-rc.2
package-lock.json Updated version references and added node_modules entry for @knighted/css in playwright package

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey
knightedcodemonkey merged commit af0d9d2 into main Jan 17, 2026
6 checks passed
@knightedcodemonkey
knightedcodemonkey deleted the bananas branch January 17, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants