chore: downgrade lightningcss. - #63
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 14 14
Lines 4105 4105
Branches 738 738
=======================================
Hits 3829 3829
Misses 249 249
Partials 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR downgrades the lightningcss dependency from version 1.30.2 to 1.30.1 to avoid issues reported in the upstream lightningcss repository. The @knighted/css package version is bumped from 1.1.0-rc.4 to 1.1.0-rc.5 to reflect this change.
Changes:
- Downgraded
lightningcssdependency from ^1.30.2 to ^1.30.1 in the css package - Bumped
@knighted/cssversion from 1.1.0-rc.4 to 1.1.0-rc.5 - Updated the playwright package to use the new @knighted/css version
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/css/package.json | Bumped package version to rc.5 and downgraded lightningcss to 1.30.1 |
| packages/playwright/package.json | Updated @knighted/css dependency to match new rc.5 version |
| package-lock.json | Updated lockfile entries for lightningcss 1.30.1 and all platform-specific binaries |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid the issues reported by:
v1.30.2? "Error: failed to deserialize; expected an object-like struct named Specifier, found ()" parcel-bundler/lightningcss#1081