refactor: remove unused code and superfluous test arguments in loader bridge - #65
Closed
knightedcodemonkey with Copilot wants to merge 7 commits into
Closed
refactor: remove unused code and superfluous test arguments in loader bridge#65knightedcodemonkey with Copilot wants to merge 7 commits into
knightedcodemonkey with Copilot wants to merge 7 commits into
Conversation
Co-authored-by: knightedcodemonkey <139886941+knightedcodemonkey@users.noreply.github.com>
Co-authored-by: knightedcodemonkey <139886941+knightedcodemonkey@users.noreply.github.com>
Co-authored-by: knightedcodemonkey <139886941+knightedcodemonkey@users.noreply.github.com>
Co-authored-by: knightedcodemonkey <139886941+knightedcodemonkey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add loader bridge for CSS module hashed class names
refactor: remove unused code and superfluous test arguments in loader bridge
Jan 19, 2026
Owner
|
closing in favor of #64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed code review feedback on commit 8533ab7 identifying unused code duplication and unnecessary test parameters.
Changes
collectNamedExportsfunction: Duplicated logic fromresolveCssModules, never calledcallPitchhelper to omit unusedpreviousRequestanddataparametersThe pitch function signature requires three parameters per webpack's
PitchLoaderDefinitionFunctioninterface, but the implementation only usesremainingRequest. Tests now use a helper that maintains type safety while omitting the unused parameters:✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.